1704080 - [Proton] Elastic overscroll does not work if there are no vertical or horizontal scrollbars present on the site

Status: REOPENED

(Core :: Panning and Zooming, defect, P3)

Description

[Timea Cernea [:tbabos][inactive]]

Affected Versions:
Nightly 89.0a1
apz.overscroll.enabled true

Tested On:
MacOS 10.15

Steps to Reproduce:

1. Go to a page that does not have vertical scroll, ex: Google.com - and swipe up-down
2. Go to a page that does not have horizontal scroll, ex: facebook feed, 9gag, reddit - and swipe left-right

Expected Results:
Swiping in either direction on each of the sites should toggle the overscroll effect.

Actual Result:
The rubberbanding effect is not toggled if there are no scrollbars (horizontal or vertical) on the site.

Please see attached recording for reference: https://drive.google.com/file/d/1FOuDMQmwNP682j_K_ElaG0VoniTye7dm/view?usp=sharing
Works on Safari and Chrome.

Comment 1

[Botond Ballo [:botond]]

The expectation here seems to be in conflict with bug 1686151, which suggests that overscroll should only be enabled if the page is scrollable along at least one axis.

Comment 2

[Martin Balfanz [:mbalfanz]]

I can't confirm what is described in bug 1686151. On Mac, our main reference is Safari, and Safari allows overscrolling for non-scrollable pages.

The other bug references Edge and Chromium Edge, so maybe it's Windows specific behavior? (Though I also can't confirm on my windows device)

Regardless, I consider this bug as valid and think that we should go ahead, at least for MacOS.

Comment 4

[Botond Ballo [:botond]]

Not a release blocker but we will try to fix this before release. There may be some interactions with swipe navigation for the horizontal direction.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

I don't see the Chromium Edge behavior on my Windows laptop either. It looks Chromium Edge allows overscrolling on both directions even if the page in question is not scrollable either directions. Presumably we can just allow overscrolling on the root scroller even if it's not scrollable on all platforms.

Note about the interactions with swipe navigation on Mac, overscrolling only happens in the directions where history navigation can not happen, i.e. if there is no forward history, then overscrolling happens on swiping right to left, in other words, overscrolling doesn't happen on swipe left to right if there's backward history. This principal seems to be also effective even if swipe navigation is disabled by the system setting.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1704080 - Factor out ScrollDirectionsForDelta(const ParentLayerPoint&). r?botond

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1704080 - Add AsyncPanZoomController::GetScrollableDirections. r?botond

Depends on D115424

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1704080 - Handoff pan gestures to the root content scroller depending on whether child/root frame is scrollable or not. r?botond

And overscroll the root content scroller even if it's not scrollable.

The conditions when we handoff are;

1. Handoff to the root unconditionally if the subframe is not scrollable
   with the given pan delta
2. Handoff to the root if both the subframe and the root are scrollable
   with the given pan delta

Depends on D115425

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a9ea6e86e2c
Factor out ScrollDirectionsForDelta(const ParentLayerPoint&). r=botond
https://hg.mozilla.org/integration/autoland/rev/71069fb39ec1
Add AsyncPanZoomController::GetScrollableDirections. r=botond
https://hg.mozilla.org/integration/autoland/rev/24335aad5608
Handoff pan gestures to the root content scroller depending on whether child/root frame is scrollable or not. r=botond

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9a9ea6e86e2c
https://hg.mozilla.org/mozilla-central/rev/71069fb39ec1
https://hg.mozilla.org/mozilla-central/rev/24335aad5608

Comment 11

[Andrei Purice]

Verified fixed in the latest Nightly 90.0a1 (2021-05-23) on MacOS 11.2.3, MacOS 11.0.1 and MacOS 10.14.

Comment 12

[Botond Ballo [:botond]]

Reopening as this was backed out in bug 1712874. We will consider re-landing it after implementing dominant axis scrolling in bug 1713403, although we may want to revisit whether this behaviour is valuable at all (I've heard mixed feedback).

Comment 13

[Botond Ballo [:botond]]

(Given the timing, a re-landing is unlikely to happen for 90.)

Comment 14

[Hiroyuki Ikezoe (:hiro)]

Confirmed Edge also does overscroll in non-scrollable cases.

Comment 15

[Botond Ballo [:botond]]

I'm updating the severity of this bug to S3, as this concerns an edge case in a cosmetic feature, it does not prevent the user from making use of a site's functionality in any way.

In addition, we have been shipping the current behaviour on Mac for over a year and we have not received any bug reports about it.

We can still explore making this change in advance of enabling overscroll by default on Windows (hence I am keeping it as a dependency of the overscroll-windows meta bug), but it doesn't need to be on the S2 list.

Comment 16

[Hiroyuki Ikezoe (:hiro)]

Moving this bug as a blocker of overscroll-post rather than overscroll-windows since this behavior has been there on MacOS environments and on Windows as well on nightly, there's no complain about this behavior.