User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.2b) Gecko/20020919 Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.2b) Gecko/20020919 I've just discovered that OS/2 disappeared from 'Operating System' list. What's wrong? Reproducible: Always Steps to Reproduce: 1. 2. 3.
I mean the list offered on creating bug through Bugzilla Helper.
cute, half of the platforms aren't in http://bugzilla.mozilla.org/enter_bug.cgi?product=Bugzilla&format=guided
This is by design. That form has been made simpler by eliminating less common cases. You can always set your OS to "Other" and a QA person will set it correctly. Or, you can use the standard form. Gerv
Sorry Grev, but I would wager OS/2 has just as many users as FreeBSD or sunOS. That's not a good argument. Why not make the field a LOT more intelligent? Like have a very small list to select from, but allow autodetection of any operating system. The "other" assignment is a REAL pain as it can cause OS/2 bugs to be lost for many weeks (which has happened)
*** Bug 166277 has been marked as a duplicate of this bug. ***
> Why not make the field a LOT more intelligent? Like have a very small list to > select from, but allow autodetection of any operating system. That sounds like a very good idea. And I think I know how we can do it really easily. I'll look at implementing that ASAP. Gerv
This is how you do it. Change the block which produces those select menus so that if there's a default, it's automatically included even if it's not in the list. The defaults are set using detection in enter_bug.cgi. This will allow us to simplify by removing more of the minority OSes from the list, too, because they will be caught by this mechanism. +[% BLOCK select %] + <select name="[% sel %]"> + [%- FOREACH x = $sel %] + <option value="[% x FILTER html %]" + [% " selected=\"selected\"" IF x == default.$sel %]> + [% x FILTER html -%] + </option> + [%- END %] + </select> +[% END %] -> +[% BLOCK select %] + <select name="[% sel %]"> + [%- IF default.$sel %] + <option value="[% default.$sel FILTER html %]" selected="selected"> + [% default.$sel FILTER html -%] + </option> + [% END %] + [%- FOREACH x = $sel %] + [% NEXT IF x == default.$sel %] + <option value="[% x FILTER html %]"> + [% x FILTER html -%] + </option> + [%- END %] + </select> +[% END %] I'll make a proper patch soon; I hope to get the Helper checked into Bugzilla itself as example code (bug 171770). That'll make it easier to fix. Gerv
Gerv, was this fixed by the checking on bug 171770?
Dave: nope :-) I checked in the Helper exactly as it's being used on b.m.o., except with the change you suggested. I've just added a patch here to solve the reported problem. Gerv
I'm afraid this didn't make the b.m.o. upgrade train - I was pushing for it, but no-one was able to find time to review the patch :-( Gerv
Comment on attachment 103905 [details] [diff] [review] Patch v.1 r=justdave a=justdave
myk: can I persuade you to CVS update template/en/default/bug/create/create-guided.html.tmpl ? :-) Fixed. Checking in template/en/default/bug/create/create-guided.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v <-- create-guided.html.tmpl new revision: 1.2; previous revision: 1.1 done Gerv
This isn't working.
restoring fixed state. bugzilla.mozilla.org has not yet upgraded since this was checked in. If it's still broken after b.m.o updates, then you can reopen.
*** Bug 227165 has been marked as a duplicate of this bug. ***