1704669 - Deduplicate and consolidate checkmark icons across the tree

Status: VERIFIED FIXED

(Firefox :: Theme, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

After bug 1699889, the following duplicate checkmarks will exist:

• chrome/toolkit/skin/classic/global/icons/success.svg
• chrome/toolkit/skin/classic/global/icons/check.svg

We also have this old DevTools checkmark around which we should probably change to use the shared one.

• browser/chrome/devtools/skin/images/check.svg

Comment 1

[Tim Nguyen :ntim]

fwiw, success.svg is linked to https://searchfox.org/mozilla-central/rev/3de2db87f3c9001ae478318d47a2ca3427574382/browser/themes/shared/icons/success-animation.svg . So that should be removed as well or be updated.

Comment 2

[Bernard Igiri]

The success-animation.svg has been split out into Bug 1716827 to avoid scope creep.

Comment 3

[Bernard Igiri]

Attachment: Bug 1704669 - Deduplicate and consolidate checkmark icons across the tree r=mconley

Replaced instances of success.svg with check.svg and removed success.svg.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a53594576d1
Deduplicate and consolidate checkmark icons across the tree r=mconley,desktop-theme-reviewers,Itiel

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5a53594576d1

Comment 6

[Rares Doghi, Desktop QA]

Hi Mike, can you please tell us which icons are these ? where can we find them ?

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Hi Rares,

Sorry for the delay. The success.svg icons were de-duplicated to check.svg, meaning that to verify this, you need to look at all of the old places that success.svg was being used. Those places are:

• about:logins (after successfully copying a username or password to the clipboard)
• about:config (when editing a value)
• about:addons (verified add-ons)

Comment 8

[Rares Doghi, Desktop QA]

Thank you Mike, I was able to verify these on Windows, Mac and Ubuntu in our latest Nightly build 91.0a1 (2021-07-08), I will mark this task accordingly.

Comment 9

[Bernard Igiri]

Attachment: Bug 1704669 - Removing unused/unwanted Confirmation Hints r=harry

Removing unused and unwanted Confirmation Hints.

Comment 10

[Phabricator Automation]

Comment on attachment 9241865 [details]
Bug 1704669 - Removing unused/unwanted Confirmation Hints r=harry

Revision D126016 was moved to bug 1703979. Setting attachment 9241865 [details] to obsolete.