1705109 - Unable to upload file to WeTransfer - remove WeTransfer provider

Status: VERIFIED FIXED

(Thunderbird :: FileLink, defect, P2)

Description

[Tristan Miller]

I have WeTransfer set as the (only) FileLink service. When I try to use FileLink to send a file, I usually (but not always) get an error dialog with the message "Unable to upload FILENAME to WeTransfer." (where FILENAME is the actual filename). The following error gets printed to the Error Console:

WebExtensions: Error:
_request moz-extension://e0a6af9e-e027-4c28-94e1-ce22cb1705c4/background/background.js:64
ext-cloudFile.js:128

Trying to send the same file via the WeTransfer website works as expected.

It would be helpful if the error messages (both in the error dialog and the Error Console) were more specific. Or if this is a persistent problem on WeTransfer's end, possibly Thunderbird shouldn't be suggesting it in the Preferences menu.

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Unable to upload [user file] to WeTransfer

Confirming exactly as described for 78.10.1 (32-bit) and 90.0a1 (2021-05-06) (64-bit).
Uploading files is failing more often than not, with the error alert and the exact console errors described by reporter in comment 0.

The UX of this is pretty poor.

• It's totally not obvious from the alert as to what could be the reason, what the status is after upload fail, or what to do next.
• No automatic retry (why not), and not obvious how to retry manually (by using Convert To... > WeTransfer)
• In spite of failure without retry, the spinner keeps going forever (see screenshot), although the attachment as been already marked as "Regular attachment", as seen in Convert to... context menu. Both conversion options are enabled, which is confusing.

Comment 2

[Geoff Lankow (:darktrojan)]

Looks like WeTransfer have broken it. The authorisation request we send now receives

{
  "success" : false,
  "token": ""
}

instead of a successful response. Magnus, Ryan, do you know who to contact about this?

Comment 3

[Thomas D. (:thomas8)]

Also note that there's the other problem mentioned on another bug that apparently users have no way of using WeTransfer's paid service with Thunderbird as it's set up for the free login-less service.

Comment 4

[Geoff Lankow (:darktrojan)]

Just tried again. The problem from comment 2 has gone away, now there's HTTP 403 errors from Amazon S3.

Thomas, that sounds like it should be a different bug.

Comment 5

[carterbrandon]

For what it's worth, WeTransfer have just given me a direct tweet response after I alerted them to this issue "We no longer offer support with the Thunderbird integration, sorry about that. I'd recommend using our website https://wetransfer.com directly to transfer your files.". If by that they mean they've stopped it working (rather than just 'it's not our problem if it's stopped working'), then I suppose Thunderbird should take it off the list of Filelink providers.

Comment 6

[Vrehosk]

Thunderbird should take it off the list of Filelink providers. Suggestions? Thanks.

Comment 7

[Vrehosk]

Good day; I have another problem: Before when I wanted to, I could change colors in text and background when writing a message, now I can't. The options appear but don't work. ¿?

Comment 8

[Tristan Miller]

(In reply to Vrehosk from comment #7)

Good day; I have another problem: Before when I wanted to, I could change colors in text and background when writing a message, now I can't. The options appear but don't work. ¿?

You'll have to file a separate bug report for that, then. This report is only for discussion of the WeTransfer issue.

Comment 9

[Geoff Lankow (:darktrojan)]

(In reply to Vrehosk from comment #6)

Thunderbird should take it off the list of Filelink providers. Suggestions? Thanks.

We intend to.

Comment 10

[Magnus Melin [:mkmelin]]

We haven't got any real answer back, so going to take it out.

Comment 11

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1705109 - Remove WeTransfer FileLink provider. r=mkmelin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2efab6a04dfa
Remove WeTransfer FileLink provider. r=mkmelin

Comment 13

[Geoff Lankow (:darktrojan)]

Comment on attachment 9231091 [details]
Bug 1705109 - Remove WeTransfer FileLink provider. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): WeTransfer servers no longer support this code
User impact if declined: Users get offered the use of code that doesn't work
Testing completed (on c-c, etc.): Nothing to test, I've checked the add-on is gone
Risk to taking this patch (and alternatives if risky):

Comment 14

[Wayne Mery (:wsmwk)]

Remove also from 78? We still have 3 months of official version 78 support, plus hangers on for many months.
This gets reported in support posts.

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9231091 [details]
Bug 1705109 - Remove WeTransfer FileLink provider. r=mkmelin

[Triage Comment]
Approved for beta

Comment 16

[Geoff Lankow (:darktrojan)]

Comment on attachment 9231091 [details]
Bug 1705109 - Remove WeTransfer FileLink provider. r=mkmelin

(In reply to Wayne Mery (:wsmwk) from comment #14)

Remove also from 78? We still have 3 months of official version 78 support, plus hangers on for many months.
This gets reported in support posts.

Yes but I'm not sure if the patch works on 78. I guess it probably does, so I'll set the flag and fix it if there's a problem.

Comment 17

[Rob Lemley [:rjl]]

Thunderbird 91.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/fabdd10fd82c

Comment 18

[Rob Lemley [:rjl]]

Attachment: remove_wetransfer_esr78.patch

The patch does not apply cleanly, but I think I managed okay.

Specifically, the MailGlue.jsm changes do not seem relevant as the _developerToolboxInit() function is not on c-esr78, and I don't see the string "WeTransfer" anywhere in the file. It looks like something for e10s anyway.

Comment 19

[Geoff Lankow (:darktrojan)]

Comment on attachment 9232219 [details] [diff] [review]
remove_wetransfer_esr78.patch

Review of attachment 9232219 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, that's fine. The MailGlue stuff was to disable the add-on in the Developer Toolbox process, where it was being a PITA. I don't think it was needed in 78.

Comment 20

[Wayne Mery (:wsmwk)]

Comment on attachment 9231091 [details]
Bug 1705109 - Remove WeTransfer FileLink provider. r=mkmelin

[Triage Comment]
Approved for esr78

Comment 21

[Rob Lemley [:rjl]]

Thunderbird 78.13.0:
https://hg.mozilla.org/releases/comm-esr78/rev/cf5d43021000

Comment 22

[WaltS48 [:walts48]]

Thunderbird 78.13.0 on Windows 10.