1706320 - The space between the rows of text of the “Import Error” and “Import Complete” modals seems larger than it should be

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: space between rows.png

[Affected Versions]:

• Firefox Nightly 89.0a1 (Build ID: 20210417095008)
• Firefox Nightly 90.0a1 (Build ID: 20210419221626)

[Affected Platforms]:

• Linux Mint 20
• Windows 10
• macOS 11.1

[Prerequisites]:

• Have Firefox open.
• From the “about:config” page, have signon.management.page.fileImport.enabled set to true.
• Have a correct CSV file containing valid login data.

[Steps to reproduce]:

1. Navigate to “about:logins”.
2. Click the meatball menu button (“...”).
3. Choose the “Import from a File...” option.
4. Choose the CSV from prerequisites and import it.
5. Observe the text of the “Import Complete” modal.

[Expected result]:

• The space between the rows of text is smaller.

[Actual result]:

• The space between the rows of text is larger than in the documentation.

[Notes]:

• This issue is also applicable for the “Import Error” modal.
• The issue seems to have been introduced as a fix in Bug 1701690.
• Attached is a screenshot of the issue compared to the documentation.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:sgalich, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 2

[Janvi Bajoria [:janvi01]]

Hey, I would like to work on this as an outreachy applicant.

Comment 3

[Sergey Galich [:serg]]

Hey Janvi, please go ahead and thank you!

Comment 4

[Janvi Bajoria [:janvi01]]

Hey, I noticed line-height of the modal content is set to 1.8em which is causing the space between rows larger.

Comment 5

[Janvi Bajoria [:janvi01]]

reducing line-height to 1.4em looks acc to the documentation.

Comment 6

[Janvi Bajoria [:janvi01]]

I am submitting a patch, please review it. Thanks!

Comment 7

[Janvi Bajoria [:janvi01]]

Attachment: Bug 1706320 - fixed the space between rows of text of Import complete and Import Error modal r?sgalich

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10fe53f2eaf8
fixed the space between rows of text of Import complete and Import Error modal r=sgalich

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/10fe53f2eaf8

Comment 10

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issue is no longer reproducible. The space between the rows of the Import Complete and Import Error messages is smaller. Tested on Firefox Nightly 101.0a1 (Build ID: 20220411094830) on Windows 10, macOS 11.6 and Linux Mint 20.2.