1707273 - Mail header fields unreadable on macOS w/ dark mode

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Rob Lemley [:rjl]]

Attachment: image.png

Thunderbird 89.0b1
macOS 10.15.7 in Dark Mode
System Theme

The fields and button labels in the mail header pane are dark text on dark background.

Comment 1

[Alessandro Castellani [:aleca] (PTO until Apr 21st)]

The problem is caused by this attribute: https://searchfox.org/comm-central/rev/bb3eb2b4cb4b17405e8efcc423563a7a07473292/mail/themes/osx/mail/messageHeader.css#12-14

Confirmed it's a macOS only issue.

Comment 2

[Alessandro Castellani [:aleca] (PTO until Apr 21st)]

Attachment: 1707273-message-header.diff

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9218052 [details] [diff] [review]
1707273-message-header.diff

Many thanks for fixing this.

Comment 4

[Alessandro Castellani [:aleca] (PTO until Apr 21st)]

Comment on attachment 9218052 [details] [diff] [review]
1707273-message-header.diff

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: wrong text color in message header with dark theme
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b49c9f29fc52
[macOS] Fix wrong text color in the message header for dark themes. r=Paenglab

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9218052 [details] [diff] [review]
1707273-message-header.diff

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 89.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/67631ad6ab6d

Comment 10

[Jason]

Confirm the issue is resolved in 89.0b2

Comment 11

[Rob Lemley [:rjl]]

(In reply to Jason from comment #10)

Confirm the issue is resolved in 89.0b2

thanks!

Comment 12

[doug2]

Thanks! Working on Win10 89.0b3.