1707384 - Choices in drop-down list are very difficult to read with proton dark theme enabled

Status: VERIFIED FIXED

(Firefox :: Foxfooding, defect)

Description

[Liam England]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Actual user agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

1. Visit about:addons, click Themes, and enable dark theme
2. Visit https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

Actual results:

The choices in the drop-down menus are very difficult to read because of dark text on a dark background.

Expected results:

The text should be readable.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Add-ons Manager' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alex Cornestean]

Hello,

I can fully reproduce the issue on the latest Nightly (90.0a1/20210425214750) and maybe, possibly partially on Beta (89.0b4/20210425185730) under Windows 10 x64 and Ubuntu 16.04 LTS. Release (88.0/20210415204500) does not appear affected. Alongside the page mentioned in the original description, I found another one where the issue occurs: https://www.nvidia.com/Download/index.aspx.

To be more specific about what I said above, please see the observations below and the attached screenshots as well:

Nightly – text color in drop-downs is black on dark grey background
Beta – text color in dropw-downs is white on dark grey background
Release – text color is black in drop-downs on white background.

It appears that the new Proton UI has caused styling from the theme to leak to drop-down menus.

Also performed a bisection with the following results:

8:17.23 INFO: No more integration revisions, bisection finished.
8:17.23 INFO: Last good revision: 8908151379dc2ae9f5594558ede67711e3617010
8:17.23 INFO: First bad revision: 593396efa9385dc05a072be49ed6bceda05efdf1
8:17.23 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8908151379dc2ae9f5594558ede67711e3617010&tochange=593396efa9385dc05a072be49ed6bceda05efdf1

Regressor: https://bugzilla.mozilla.org/show_bug.cgi?id=1706496 - Specify background along with color for menupopups

Please note that during the bisection:

• dropw-downs with white text against dark grey background (text being visible) were considered GOOD.
• dropw-downs with black text against dark grey background (text not being properly visible) were considered BAD.

Comment 3

[Alex Cornestean]

Attachment: Nightly dropdown.png

Comment 4

[Alex Cornestean]

Attachment: Beta dropdown.png

Comment 5

[Alex Cornestean]

Attachment: Release dropdown.png

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

This bug doesn't look to be in the right component, the only relationship with the Add-ons Manager is the fact that as part of the STR there is a mention to the about:addons page, but to switch to the dark theme which is a builtin theme.

Besides that, this issue seems to be related to the a drop down part of a content page while the builtin dark theme is enabled.

Moving it to foxfooding to give it more visibility.

Comment 7

[krupa raj [:krupa--use this to needinfo]]

needinfo'ing @rtestard for thoughts on this bug since this is not related to add-ons manager but to the built-in theme

Comment 8

[Peter deHaan [:pdehaan]]

Sounds similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1707296

Comment 10

[Romain Testard [:RT]]

I'm marking bug 1707296 as a dupe since this bug seems to have more details.
The identified regressor (bug 1706496) has not yet been uplifted to Beta, which likely explains why the same issue does not apply to Beta.
I'm adding a comment to avoid uplift of bug 1706496 and make sure QA is done in dark mode per STR here.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Please next time ni? me on regressions, or at least flag them as such so I don't miss them :)

I'll look at this asap.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1707384 - Fix menu.css color declaration to apply to the popup rather than the menuitems. r=dao,Gijs

This used to work by chance actually, because for the content select menuitems explicitly
inherit their color.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c194dac64e0
Fix menu.css color declaration to apply to the popup rather than the menuitems. r=Gijs

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5c194dac64e0

Comment 15

[Pascal Chevrel:pascalc]

Emilio, is the uplift in bug 1706496 dependent on uplifting this bug as well?

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9218624 [details]
Bug 1707384 - Fix menu.css color declaration to apply to the popup rather than the menuitems. r=dao,Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner CSS fix.
• String changes made/needed: none

Comment 17

[Alex Cornestean]

Verified the fix on the latest Nightly (90.0a1/20210428100720) under Windows 10 x64 and Ubuntu 16.04 LTS.

The menu items are now white and visible on the dark grey background of the popup. For further details, see the attached screenshot.

Comment 18

[Alex Cornestean]

Attachment: 2021-04-28_15h50_37.png

Comment 19

[Pascal Chevrel:pascalc]

Comment on attachment 9218624 [details]
Bug 1707384 - Fix menu.css color declaration to apply to the popup rather than the menuitems. r=dao,Gijs

Approved for 89 beta 6, thanks.

Comment 20

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/aec56f6c7933

Comment 21

[Alex Cornestean]

Verified the fix on the latest Beta (89.0b7/20210502185943) under Windows 10 x64 and Ubuntu 16.04 LTS.

The menu items are now white and visible on the dark grey background of the popup. For further details, see the attached screenshot.

Comment 22

[Alex Cornestean]

Attachment: 2021-05-04_13h07_36.png