1707588 - Sync vendored puppeteer to v9.1.1

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P2)

Description

[Julian Descottes [:jdescottes]]

Version 9.0.0 is the most recent release:

https://github.com/puppeteer/puppeteer/releases/tag/v9.0.0

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

They just released a new version:
https://github.com/puppeteer/puppeteer/releases/tag/v9.1.0

Comment 2

[Julian Descottes [:jdescottes]]

We can update to https://github.com/puppeteer/puppeteer/releases/tag/v9.1.1 it still supports Node 10

Comment 3

[Julian Descottes [:jdescottes]]

I had to "cherry pick" (as in "do the same thing manually") the following commit: https://github.com/puppeteer/puppeteer/commit/4796382f01b9afe7762d864a6486efbefecb868f

In tag v9.1.1, dependencies in package.json were not fixed, and one those forced us to retrieve a non backward compatible version of typescript which was making the compile fail.

So I locally fixed dependencies on my branch, based on what we have in our package-lock.json in mozilla-central (unless there is a better solution to pick a set of versions that should work?). There won't be anything to sync upstream for that since the same goal has already been achieved in the main repo via the commit linked above.

Comment 4

[Julian Descottes [:jdescottes]]

Note that since Node 12 support is on its way, I'll just use this as an intermediary sync and will jump on the 10.0.0 sync right after

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1707588 - [puppeteer] Sync vendored puppeteer to v9.1.1

PR to upstream the comment update: https://github.com/puppeteer/puppeteer/pull/7324

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70e57d0764fb
[puppeteer] Sync vendored puppeteer to v9.1.1 r=webdriver-reviewers,whimboo

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/70e57d0764fb