Closed Bug 1707588 Opened 5 months ago Closed 3 months ago

Sync vendored puppeteer to v9.1.1

Categories

(Remote Protocol :: Agent, task, P2)

task
Points:
2

Tracking

(firefox91 fixed)

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: [bidi-m1-mvp] )

Attachments

(1 file)

Version 9.0.0 is the most recent release:

https://github.com/puppeteer/puppeteer/releases/tag/v9.0.0

No longer depends on: 1694506
Points: --- → 2
Priority: -- → P3
Summary: Sync vendored puppeteer to v9.0.0 → Sync vendored puppeteer to v9.1.0
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

We can update to https://github.com/puppeteer/puppeteer/releases/tag/v9.1.1 it still supports Node 10

Summary: Sync vendored puppeteer to v9.1.0 → Sync vendored puppeteer to v9.1.1

I had to "cherry pick" (as in "do the same thing manually") the following commit: https://github.com/puppeteer/puppeteer/commit/4796382f01b9afe7762d864a6486efbefecb868f

In tag v9.1.1, dependencies in package.json were not fixed, and one those forced us to retrieve a non backward compatible version of typescript which was making the compile fail.

So I locally fixed dependencies on my branch, based on what we have in our package-lock.json in mozilla-central (unless there is a better solution to pick a set of versions that should work?). There won't be anything to sync upstream for that since the same goal has already been achieved in the main repo via the commit linked above.

Note that since Node 12 support is on its way, I'll just use this as an intermediary sync and will jump on the 10.0.0 sync right after

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/70e57d0764fb
[puppeteer] Sync vendored puppeteer to v9.1.1 r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Priority: P3 → P2
You need to log in before you can comment on or make changes to this bug.