1707869 - Trying to open native context menus for items found inside panels (while in full screen mode) doesn’t work

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Affected versions

• Firefox 90.0a1 (BuildId:20210426213158)
• Firefox 89.0b4 (BuildId:20210425185730)

Affected platforms

• macOS 10.14
• macOS 11.3

Unaffected platforms

• Windows 10 64bit.
• Ubuntu 20.04 64bit.

Preconditions

• Have the widget.macos.native-context-menus and browser.proton.enabled prefs enabled.

Steps to reproduce

1. Launch Firefox.
2. Enter in full screen mode.
3. Click on the Hamburger menu.
4. Select the “Bookmarks” option.
5. Try opening the context menu for a listed bookmark.

Expected result

• The context menu opens successfully.

Actual result

• The context menu doesn’t open. It seems that the context menu tries to open but it gets closed automatically (almost instantly).

Regression Range

• This issue is reproducible only with native context menus enabled. This issue seems to be reproducible on builds from 2021-03-23 as well (When the initial support for native context menus landed in Bug 1698997)

Additional Notes

• Access the following link for screencast (Mozilla account needed).
• Encountered this on the Bookmarks & History items. This issue is also reproducible from the bookmarks & history items exposed from the library panel.
• This is also reproducible on the context menu opened for the downloaded items from the download panel.

Comment 2

[Stephen A Pohl [:spohl]]

Attachment: Bug 1707869: Introduce helper to detect when native context menus are enabled via prefs on macOS. r=mstange

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Bug 1707869: Disable context menu tracking when native context menus are used to avoid accidental closing of context menus in fullscreen mode. r=mstange

Depends on D113579

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/705b32ab24dc
Introduce helper to detect when native context menus are enabled via prefs on macOS. r=mstange
https://hg.mozilla.org/integration/autoland/rev/eaf8bc2be960
Disable context menu tracking when native context menus are used to avoid accidental closing of context menus in fullscreen mode. r=mstange

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/705b32ab24dc
https://hg.mozilla.org/mozilla-central/rev/eaf8bc2be960

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:spohl, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Stephen A Pohl [:spohl]]

Markus will be handling uplifts. Forwarding n-i.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/2348a6211557
https://hg.mozilla.org/releases/mozilla-beta/rev/83707d3fc298

Comment 10

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 89.0b8 (BuildId:20210504185920) and Firefox 90.0a1 (BuildId:20210504214950) on macOS 10.15 & 10.14