1707950 - Address bar extensions chiclet doesn't match Figma

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea]]

Attachment: 2021-04-27_13h01_40.png

Affected versions

• Fx90.0a1 2021-04-27
• Firefox 89 beta 4

Affected platforms

• Windows 10 64-bit
• OSX 10.14

Steps to reproduce

1. Launch Firefox and go to about:addons
2. Install any addon that has a settings page. (e.g. uBlock)
3. From the browser's toolbar, click on the installed addon icon and then on settings to open addon's settings page
4. Observe the extension chiclet icon in address bar

Expected result

• Extension chiclet matches Figma, the icon is not filled, same as shield and lock icons.

Actual result

• Icon is filled, same as Add-ons Manager tab favicon.

Regression range

• Introduced with bug 1702690, but not an actual regression

Note

• This might be expected as well, but from MR1 Icons - List- Desktop doc (lines 134 - 138) is hard to tell if the address bar icons should be filled in or not.

Comment 1

[Marco Bonardo [:mak]]

Sam, do you know if the expected icons have been used here?

Comment 2

[Marco Bonardo [:mak]]

The new svg looks filled in a viewer

Comment 3

[Sam Foster [:sfoster] (he/him)]

(In reply to Marco Bonardo [:mak] from comment #1)

Sam, do you know if the expected icons have been used here?

The reporter is correct, this should be the hollow version of the icon. That's extension.svg in the google drive folder. We might need to update the spreadsheet too, if the mistake originated there. Details for both in: https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE

Comment 4

[Marco Bonardo [:mak]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

The reporter is correct, this should be the hollow version of the icon. That's extension.svg in the google drive folder. We might need to update the spreadsheet too, if the mistake originated there. Details for both in: https://docs.google.com/document/d/114gLvaDoZpYnhtK_pPGgbMizphBbjrKp23_YHmWHHLE

the spreadsheet says extension-fill.svg to replace the old extension.svg, that's probably where the problem generated. And that may also not be wrong, we probably want both depending on the ui part.
But I'm not sure we have a reference telling which icons should be hollow and which not?
The urlbar ones, the toolbar one, about:addons favicon shoukd probably be. Not sure about the icon in about:performance or about:processes, or the icon in the left pane of about:preferences.
I can probabile generate a list out of https://searchfox.org/mozilla-central/search?q=extensions%2Fextension.svg and then we must decide.

Comment 5

[Marco Bonardo [:mak]]

I made this spreadsheet to evaluate where we want hollow icon and where not. Sam, who is the right person to ask for that?
https://docs.google.com/spreadsheets/d/1hazjiPGC7tam6rZ4OInRrFjwdgdVPbXdihwxcPlfM1M/edit?usp=sharing

Comment 6

[Marco Bonardo [:mak]]

I asked to Emanuela in the #proton-icon-handoff Slack.

Comment 7

[Marco Bonardo [:mak]]

Attachment: Bug 1707950 - Use hollow version of the extension icon. r=sfoster,rpl

Replace the basic extension.svg icon with an hollow version, move the filled
icon to extension-filled.svg and use this one for UIs referring to about:addons.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fae41c030bf1
Use hollow version of the extension icon. r=sfoster,rpl

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fae41c030bf1

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 9219237 [details]
Bug 1707950 - Use hollow version of the extension icon. r=sfoster,rpl

Beta/Release Uplift Approval Request

• User impact if declined: Part of MR1 design.
  We're using the wrong icon for extensions, we should be using the hollow version instead of the filled one
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Check icons, use the document in the url field as a reference
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Replacing an icon
• String changes made/needed:

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9219237 [details]
Bug 1707950 - Use hollow version of the extension icon. r=sfoster,rpl

Low risk icon replacement, approved for 89 beta 8, thanks.

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8793b43b3c5a

Comment 13

[Pablo]

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b8