De-duplicate lightbulb icons
Categories
(Firefox :: Theme, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | verified |
People
(Reporter: bugzilla, Assigned: sfoster)
References
(Blocks 3 open bugs)
Details
(Whiteboard: [proton-cleanups][proton-icons])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1706206 +++
After bug 1707756 lands, the following duplicate icons will exist:
- browser/extensions/report-site-issue/icons/lightbulb.svg
- toolkit/themes/shared/icons/lightbulb.svg
These are tricky because one is in an in-tree extension. I tried referencing chrome://global/skin/icons/lightbulb.svg
and ../../../toolkit/themes/shared/icons/lightbulb.svg
in the report-site-issue manifest, but neither worked. Now that the report-site-issue add-on isn't shown anywhere, we could consider removing its icon altogether.
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
With the changes in this patch, the webcompat addon's icon path is updated to use the shared lightbulb icon in toolkit/themes/shared/icons. That works, but the resulting image URL (e.g., in about:debugging#/runtime/this-firefox) is a file:/// URL rather than a chrome:// - for me its file:///home/sfoster/moz/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/features/webcompat-reporter@mozilla.org/icons/lightbulb.svg. I'm not sure if that just looks odd or is an actual problem? It seems like that should be a chrome: URI.
Comment 3•3 years ago
|
||
(In reply to Sam Foster [:sfoster] (he/him) from comment #2)
With the changes in this patch, the webcompat addon's icon path is updated to use the shared lightbulb icon in toolkit/themes/shared/icons. That works, but the resulting image URL (e.g., in about:debugging#/runtime/this-firefox) is a file:/// URL rather than a chrome:// - for me its file:///home/sfoster/moz/firefox/obj-x86_64-pc-linux-gnu/dist/bin/browser/features/webcompat-reporter@mozilla.org/icons/lightbulb.svg. I'm not sure if that just looks odd or is an actual problem? It seems like that should be a chrome: URI.
I don't think this part is a problem; if you run a packaged build (./mach package && ./mach run --packaged
), you get a jar:file
URI, so it'll be something to do with how the target is determined by the devtools. I wouldn't worry about it while it loads on the page in question.
Assignee | ||
Comment 4•3 years ago
|
||
So, I'm not really sure where to go with this. The extension manifest validator throws if I try to use a chrome:// URL value for the icon, it (reasonably) wants a relative path only. And while I can use % override directives in the jar manifest, that seems to only work (or is only ever used) for chrome:// URL mappings.
Its possible this is actually a good candidate for an allowed-dupe, and I can land with the moz.build changes, but leave the allowed-dupes.mn entry - with a new bug filed to track it beyond these proton/MR1 changes.
Comment 5•3 years ago
•
|
||
(In reply to Sam Foster [:sfoster] (he/him) from comment #4)
Its possible this is actually a good candidate for an allowed-dupe, and I can land with the moz.build changes, but leave the allowed-dupes.mn entry - with a new bug filed to track it beyond these proton/MR1 changes.
This WFM. ISTM the report-site-issue builtin extension could just be merged into the main product at this point, I don't know that there's any benefit to it remaining an extension. Then this problem would go away. (But obviously we shouldn't try to accomplish that in this bug.)
Updated•3 years ago
|
Comment 7•3 years ago
|
||
bugherder |
Comment 8•3 years ago
|
||
Gijs can you please tell which icons are these ? where can I find the lightbulb icon ? is this related to the old Report a deceptive websites pop up menu ?
Comment 9•3 years ago
|
||
(In reply to Rares Doghi from comment #8)
Gijs can you please tell which icons are these ? where can I find the lightbulb icon ? is this related to the old Report a deceptive websites pop up menu ?
It's used in at least:
- the entry for the site issue reporter add-on (only available on devedition and nightly, IIRC) on
about:debugging#/runtime/this-firefox
- url bar tips (e.g. type "reset firefox" in the address bar)
- https only "www" suggestion box - for which you'll need to enable https only mode, as well as
dom.security.https_only_mode_error_page_user_suggestions
in about:config. You can then test by loadingspeedofanimals.com
(x-ref bug 1665057)
Comment 10•3 years ago
|
||
Hi Gijs, The only lightbulb Icon I was unable to find was the entry for the site issue reporter addon, cant find that one, I reached the about:debugging#/runtime/this-firefox but there arent any lightbulb icons there, I also installed the webcompat addon but I dont think thats the lightbulb icon im suppose to checkout.
Comment 11•3 years ago
|
||
(In reply to Rares Doghi from comment #10)
Hi Gijs, The only lightbulb Icon I was unable to find was the entry for the site issue reporter addon, cant find that one, I reached the about:debugging#/runtime/this-firefox but there arent any lightbulb icons there, I also installed the webcompat addon but I dont think thats the lightbulb icon im suppose to checkout.
Sorry, it appears this requires setting devtools.aboutdebugging.showHiddenAddons
to true
in about:config ; this is the default on unofficial (ie local) builds which is why I didn't notice.
Comment 12•3 years ago
|
||
Thanks Gijs, I was able to verify all of these now, This issue is verified as fixed in our latest Nightly 91.0a1 (2021-07-04).
Description
•