Closed Bug 1708238 Opened 3 years ago Closed 3 years ago

Logic in ExtensionPolicyService::InjectContentScripts is incompatible with cross-origin subframes

Categories

(WebExtensions :: General, defect, P1)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(Fission Milestone:M7a, firefox90 fixed)

Status:
RESOLVED FIXED
Milestone:
90 Branch
Project Flags:
Fission Milestone M7a
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: nika, Assigned: zombie)

References

Details

Attachments

(1 file)

Bug 1708238 - Stop relying on messagemanager in ExtensionPolicyService
48 bytes, text/x-phabricator-request
Details | Review

The code currently tracks MessageManager instances to locate toplevel in-process DocShell instances, however no framescripts will be loaded, and therefore the messagemanagers will never be located, for remote subframes.

This should be changed to instead iterate using a mechanism like BrowsingContextGroups.

Patch mostly by Nika Layzell; test, some tweaks (and all bugs) by me.

Assignee: nobody → tomica
Status: NEW → ASSIGNED
Severity: -- → S2
Priority: -- → P1
Fission Milestone: ? → M7a
Attachment #9219753 - Attachment description: Bug 1708238 - Stop relying on messagemanager in ExtensionPolicyService.h → Bug 1708238 - Stop relying on messagemanager in ExtensionPolicyService
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c92eba1dfa0
Stop relying on messagemanager in ExtensionPolicyService r=robwu,geckoview-reviewers,agi

https://hg.mozilla.org/mozilla-central/rev/9c92eba1dfa0

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Regressions: 1715434
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: