Closed Bug 1708238 Opened 2 months ago Closed 1 month ago

Logic in ExtensionPolicyService::InjectContentScripts is incompatible with cross-origin subframes

Categories

(WebExtensions :: General, defect, P1)

defect

Tracking

(Fission Milestone:M7a, firefox90 fixed)

RESOLVED FIXED
90 Branch
Fission Milestone M7a
Tracking Status
firefox90 --- fixed

People

(Reporter: nika, Assigned: zombie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The code currently tracks MessageManager instances to locate toplevel in-process DocShell instances, however no framescripts will be loaded, and therefore the messagemanagers will never be located, for remote subframes.

This should be changed to instead iterate using a mechanism like BrowsingContextGroups.

Blocks: 1708245

Patch mostly by Nika Layzell; test, some tweaks (and all bugs) by me.

Assignee: nobody → tomica
Status: NEW → ASSIGNED
Severity: -- → S2
Priority: -- → P1
Fission Milestone: ? → M7a
Attachment #9219753 - Attachment description: Bug 1708238 - Stop relying on messagemanager in ExtensionPolicyService.h → Bug 1708238 - Stop relying on messagemanager in ExtensionPolicyService
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c92eba1dfa0
Stop relying on messagemanager in ExtensionPolicyService r=robwu,geckoview-reviewers,agi
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.