1715434 - Registering content scripts is broken

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Geoff Lankow (:darktrojan)]

Sometime in the 90 cycle, registering ordinary content scripts broke. Neither registration by the manifest or by browser.contentScripts.register work, AFAICT.

Comment 1

[Geoff Lankow (:darktrojan)]

Gah! I found some of the problem. The toolkit code now checks the message manager group of the browser in question, but we use weird groups for the link handling behaviour.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1715434 - In Thunderbird, consider some extra message manager groups when injecting WebExt content scripts. r=zombie

Thunderbird uses these extra groups for special handling of links, and they need to be considered the same as the browsers group for WebExtensions purposes.

Comment 3

[Geoff Lankow (:darktrojan)]

This patch doesn't completely solve the problem. I'm still not seeing the right behaviour when it comes to enumerating existing browsers, like injecting scripts into already-open tabs, or removing scripts if the extension shuts down. Any ideas would be appreciated, :zombie.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d4ab051ebf7
In Thunderbird, consider some extra message manager groups when injecting WebExt content scripts. r=zombie

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1715434 - Regression test for content scripts. r=john.bieling

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1715434 - Update compose/message display script loading behaviour to match content scripts. r=john.bieling

Depends on D119958

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7d4ab051ebf7

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9231130 [details]
Bug 1715434 - In Thunderbird, consider some extra message manager groups when injecting WebExt content scripts. r=zombie

Beta/Release Uplift Approval Request

• User impact if declined: Thunderbird extensions won't be able to use the contentScripts API for all of ESR 91. This does not affect Firefox.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9231130 [details]
Bug 1715434 - In Thunderbird, consider some extra message manager groups when injecting WebExt content scripts. r=zombie

Low risk in early betas, approved for uplift in 91 beta 4, thanks

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8b3763c79939

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/412c4661446b
Regression test for content scripts. r=john.bieling
https://hg.mozilla.org/comm-central/rev/fb9fe9eb149b
Update compose/message display script loading behaviour to match content scripts. r=john.bieling

Comment 12

[John Bieling (:TbSync)]

Comment on attachment 9231303 [details]
Bug 1715434 - Regression test for content scripts. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
content scripts cannot be registered

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
The test has a small chance of failing, Geoff will look at it later.

Comment 13

[John Bieling (:TbSync)]

Comment on attachment 9231304 [details]
Bug 1715434 - Update compose/message display script loading behaviour to match content scripts. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
content scripts cannot be registered

Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky):
Low.

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9231304 [details]
Bug 1715434 - Update compose/message display script loading behaviour to match content scripts. r=john.bieling

[Triage Comment]
Approved for beta

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9231303 [details]
Bug 1715434 - Regression test for content scripts. r=john.bieling

[Triage Comment]
Approved for beta

Comment 16

[Dave Miller [:justdave]]

Thunderbird 91.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/cf13e679f69f
https://hg.mozilla.org/releases/comm-beta/rev/a5a35eb96d67

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9231130 [details]
Bug 1715434 - In Thunderbird, consider some extra message manager groups when injecting WebExt content scripts. r=zombie

Clearing the approval flag to get this off the needs-uplift radar.