Error pop up not appearing when email address is invalid
Categories
(SeaMonkey :: MailNews: Composition, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Regression)
Details
Attachments
(1 file)
|
4.17 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Need to port the follow-up bug 497572 too otherwise we get errors when using newsgroups or have invalid addresses.
[Approval Request Comment]
Regression caused by (bug #): 1693994
User impact if declined: errors instead of popups
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 2 new strings
I've not inlined the variables errorTitle and errorMsg but can do if you prefer.
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9219696 [details] [diff] [review]
1708909-invalid-address-2538.patch
tested and working lgtm r/a+
No need to inline errorTitle. errorMsg is a bit long for inlining so both can stay I think.
|
|
||
Updated•4 years ago
|
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/f6453355c0a1
Error pop up not appearing when email address is invalid. r=frg
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Comment 4•4 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/44e03fc0ef582877ce56a7841e2bd3346212773d
Error pop up not appearing when email address is invalid. r=frg a=frg
Description
•