1709511 - Add a preview Fluent file for Firefox Suggest

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

Right now Firefox Suggest strings are hardcoded in at least a couple of places, UrlbarProviderQuickSuggest.jsm, the search preferences UI, and potentially UrlbarView if the current diff in D114203 lands. We should follow the example of search interventions and put Firefox Suggest strings in a Fluent file that is not (yet) exposed to localizers. Judging by the jar.mn that packages the interventions file, such "localizations" are called "previews".

This spun out from https://phabricator.services.mozilla.com/D114203#inline-635035

Comment 1

[Drew Willcoxon :adw]

The feature name and "{$engine} Suggestions" strings are being added in bug 1725289. We still have the about:preferences#search strings, the onboarding dialog strings, and "Sponsored" and "Recommended", so we can keep this bug open until we decide what to do with them.

Comment 2

[Drew Willcoxon :adw]

The top-hit bug is adding a new string, so I'll take this bug first instead of hardcoding yet another Firefox Suggest string.

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1709511 - Add a preview Fluent file for Firefox Suggest.

This adds preview localizations for remaining Firefox Suggest strings.

I removed support for payload.helpTitle and sponsoredText. The helpTitle
code comment says it's useful for experiments with hardcoded strings, but we're
not shipping experiments as extensions anymore, and in-tree experimental/
in-development features should use preview localizations AFAICT.

Covered by existing tests:

• browser/components/urlbar/tests/browser/browser_helpUrl.js
• browser/components/urlbar/tests/browser/browser_quickSuggest*
• browser/components/preferences/tests/browser_searchQuickSuggest.js

Depends on D122550

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1175ae089daaf12fcdd06bcff668cb210711019f

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac0f9617d3e6f8be46cd99c5ca4fe8a0d20d8416

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b4db2f1bf8f
Add a preview Fluent file for Firefox Suggest. r=harry,fluent-reviewers,preferences-reviewers,flod

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7b4db2f1bf8f

Comment 8

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: Some urgent Firefox Suggest patches we want to uplift to a 92 dot release depend on this bug.

Comment 9

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

We're tracking the metabug for this work.

Comment 10

[Drew Willcoxon :adw]

Attachment: 92/mozilla-release patch

Approval Request Comment
[Feature/Bug causing the regression]: Firefox Suggest offline/online rollouts
[User impact if declined]: Needed for important rollouts on 93 and 92
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No, this is a low-level change with no visible changes
[List of other uplifts needed for the feature/fix]: See uplift coordination spreadsheet
[Is the change risky?]: Low risk relative to other uplifts needed in the patch stack
[Why is the change risky/not risky?]: This patch adds a preview Fluent file for some Firefox Suggest strings. The strings are not exposed to localizers. There are no visible changes.
[String changes made/needed]:

Comment 11

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Comment on attachment 9240784 [details] [diff] [review]
92/mozilla-release patch

Approved for 92.0.1.

Comment 12

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-release/rev/b30d4b3134ae