Closed Bug 1709511 Opened 7 months ago Closed 3 months ago

Add a preview Fluent file for Firefox Suggest

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
2

Tracking

()

RESOLVED FIXED
93 Branch
Iteration:
93.1 - Aug 9 - Aug 22
Tracking Status
firefox92 --- fixed
firefox93 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Right now Firefox Suggest strings are hardcoded in at least a couple of places, UrlbarProviderQuickSuggest.jsm, the search preferences UI, and potentially UrlbarView if the current diff in D114203 lands. We should follow the example of search interventions and put Firefox Suggest strings in a Fluent file that is not (yet) exposed to localizers. Judging by the jar.mn that packages the interventions file, such "localizations" are called "previews".

This spun out from https://phabricator.services.mozilla.com/D114203#inline-635035

Summary: Add preview Fluent files for Firefox Suggest → Add a preview Fluent file for Firefox Suggest

The feature name and "{$engine} Suggestions" strings are being added in bug 1725289. We still have the about:preferences#search strings, the onboarding dialog strings, and "Sponsored" and "Recommended", so we can keep this bug open until we decide what to do with them.

See Also: → 1725289

The top-hit bug is adding a new string, so I'll take this bug first instead of hardcoding yet another Firefox Suggest string.

Assignee: nobody → adw
Blocks: 1723160
Status: NEW → ASSIGNED
Iteration: --- → 93.1 - Aug 9 - Aug 22
Depends on: 1725289
See Also: 1725289

This adds preview localizations for remaining Firefox Suggest strings.

I removed support for payload.helpTitle and sponsoredText. The helpTitle
code comment says it's useful for experiments with hardcoded strings, but we're
not shipping experiments as extensions anymore, and in-tree experimental/
in-development features should use preview localizations AFAICT.

Covered by existing tests:

  • browser/components/urlbar/tests/browser/browser_helpUrl.js
  • browser/components/urlbar/tests/browser/browser_quickSuggest*
  • browser/components/preferences/tests/browser_searchQuickSuggest.js

Depends on D122550

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b4db2f1bf8f
Add a preview Fluent file for Firefox Suggest. r=harry,fluent-reviewers,preferences-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Flags: qe-verify-
Flags: in-testsuite+
Blocks: 1727907

[Tracking Requested - why for this release]: Some urgent Firefox Suggest patches we want to uplift to a 92 dot release depend on this bug.

We're tracking the metabug for this work.

Approval Request Comment
[Feature/Bug causing the regression]: Firefox Suggest offline/online rollouts
[User impact if declined]: Needed for important rollouts on 93 and 92
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No, this is a low-level change with no visible changes
[List of other uplifts needed for the feature/fix]: See uplift coordination spreadsheet
[Is the change risky?]: Low risk relative to other uplifts needed in the patch stack
[Why is the change risky/not risky?]: This patch adds a preview Fluent file for some Firefox Suggest strings. The strings are not exposed to localizers. There are no visible changes.
[String changes made/needed]:

Attachment #9240784 - Flags: approval-mozilla-release?

Comment on attachment 9240784 [details] [diff] [review]
92/mozilla-release patch

Approved for 92.0.1.

Attachment #9240784 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.