1709805 - [Windows 7] The "Import from <previous browser>" and "Not now" buttons from the second screen of the "about:welcome" page are wrongly displayed in the bottom part of the white modal

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: ss of the issue.png

[Notes]:

• Since there are no navigation bullets on Windows 7 and the buttons from the second screen of the "about:welcome" page are displayed in the bottom part of the white modal, a big empty space results between the modal description and the buttons.

[Affected versions]:

• Firefox Nightly 90.0a1 - Build ID: 20210505215208

[Affected Platforms]:

• Windows 7 x64

[Prerequisites]:

• Have a new Firefox profile.

[Steps to reproduce]:

1. Open the browser using the profile from prerequisites.
2. Click the "Not now" button from the bottom-right part of the page.
3. Observe the modal elements.

[Expected result]:

• All the elements are correctly displayed and there is no empty space between the text description and the buttons.

[Actual result]:

• The "Import from <previous browser>" and "Not now" buttons are displayed in the bottom part of the modal.

[Regression Window]:

• Since this issue is not reproducible with the Firefox Nightly build from 2021-05-04, using the Mozregression tool I have managed to find the following regression window:
  Last good revision: 25854de1a92c7fec1fcf01f271189cce5008bd74
  First bad revision: 88ca58d4c08e073fd52f332804a0da9a7d37b626
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=25854de1a92c7
  fec1fcf01f271189cce5008bd74&tochange=88ca58d4c08e073fd52f332804a0da9a7d37b626

From the pushlog it seems that Bug 1698204 has caused this behavior.

[Additional Notes]:

• This issue is not reproducible on Windows 10, Windows 8, macOS 10.15, and Linux Mint 20.
• Attached a screenshot of the issue.

Comment 1

[Ed Lee :Mardak]

Attachment: example rendering steps but making them invisible

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1709805 - [win7] Render steps but visually hide to maintain desired spacing r?emcminn

Remove special check for total steps and just render to then visually hide with opacity in css.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/696631b60755
[win7] Render steps but visually hide to maintain desired spacing r=emcminn

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/696631b60755

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Nightly (90.0a1 - Build ID: 20210507095221) installed on Windows 7 x64. The "Import from <previous browser>" and "Not now" buttons from the second screen of the "about:welcome" page are no longer displayed in the bottom part of the white modal. Now, the buttons are displayed as exemplified in comment 1.

Comment 6

[Ed Lee :Mardak]

Comment on attachment 9220661 [details]
Bug 1709805 - [win7] Render steps but visually hide to maintain desired spacing r?emcminn

Beta/Release Uplift Approval Request

• User impact if declined: Proton/MR1 new users on Windows 7 see buttons all the way down on the bottom edge (see attachment 9220562 [details])
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: Regressing bug 1698204
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This restores the steps indicator, which was previously specially removed for windows 7, and instead uses CSS to make it invisible so spacing is maintained across all platforms.
• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc]

Romain, do you need this fix in MR1? Thanks

Comment 8

[Ed Lee :Mardak]

Romain was asking for bug 1706478 comment 4 uplift, and this bug was a regression from that bug fix to spread out the content as windows 7 specially removed the steps indicator as part of bug 1707140.

Comment 9

[Romain Testard [:RT]]

Yes please let's uplift this one

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9220661 [details]
Bug 1709805 - [win7] Render steps but visually hide to maintain desired spacing r?emcminn

Approved for 89 beta 11 12, thanks.

Comment 11

[Ed Lee :Mardak]

With dependent bug 1698204 comment 17 uplifted, updating flag 89=affected

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/1becfdf467b8

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the latest Firefox Beta (89.0b12 - Build ID: 20210513185752) installed on Windows 7 x64. The "Import from <previous browser>" and "Not now" buttons from the second screen of the "about:welcome" page are no longer displayed in the bottom part of the white modal. Now, the buttons are displayed as exemplified in comment 1.