1710231 - Port |Bug 1095602 - remove the STATE_SECURE_HIGH, STATE_SECURE_MEDIUM, STATE_SECURE_LOW distinction from nsIWebProgressListener| to chatZilla

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

As Bug 1095602 has landed on SeaMonkey's code, should also port this to our forked cZ.

Comment 1

[Ian Neal]

Attachment: 1710231-irc-port1095602-2539.patch

[Approval Request Comment]
Regression caused by (bug #): 1095602
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9220966 [details] [diff] [review]
1710231-irc-port1095602-2539.patch

LGTM

suite/extensions/irc/js/lib/connection-xpcom.js

NIT

•        return STATE_IS_BROKEN;
    else
  

•        return [STATE_IS_SECURE, STATE_SECURE_LOW];
  

•        return STATE_IS_SECURE;
  

The else can be removed too. Now a simple if/else and The "return STATE_IS_BROKEN;" is unconditional here.

   dd("Exception getting certificate for connection: " + ex.message);
   return STATE_IS_BROKEN;

Should at least the "return STATE_IS_BROKEN;" moved to be after the catch block?

Function has no return value at the end otherwise and looks a little "unclean".

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c2c2816a5c4
Port |Bug 1095602 - remove the STATE_SECURE_HIGH, STATE_SECURE_MEDIUM, STATE_SECURE_LOW distinction from nsIWebProgressListener| to chatZilla. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/cb0ca8aa87a776b2ef2124752665e5d70ee642d6
Port |Bug 1095602 - remove the STATE_SECURE_HIGH, STATE_SECURE_MEDIUM, STATE_SECURE_LOW distinction from nsIWebProgressListener| to chatZilla. r=frg a=frg