1710421 - Upgrade webdriver crate's cookie, time, hyper, tokio, and warp dependencies

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P3)

Description

[Kai Ren]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:88.0) Gecko/20100101 Firefox/88.0

Expected results:

Please, upgrade tokio, time and cookie dependecies of webdriver crate to latest major version to be caught up with the ecosystem.

I haven't found a better place for reporting this, nor found a way to contribute this.

Thanks!

Comment 1

[Rares Doghi, Desktop QA]

I think this issue belongs to Testing > Marionette, maybe someone from our dev team can take a look and they might know what the issue is.
If its not the right component please move it to a more suitable one.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks for filing the request for dependency updates. Major version bumps are always not that easy to handle, and especially tokio might give problems as mentioned on bug 1691131. But maybe we could get started with smaller crates like cookie and time, and defer the rest to bug 1691131.

Kai, if you have interest to contribute a patch, it would be kinda appreciated. Let me know, and I can tell you what needs to be done. Otherwise we will get to it when there is a bit of time.

Comment 3

[Kai Ren]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #2)

Thanks for filing the request for dependency updates. Major version bumps are always not that easy to handle, and especially tokio might give problems as mentioned on bug 1691131. But maybe we could get started with smaller crates like cookie and time, and defer the rest to bug 1691131.

Kai, if you have interest to contribute a patch, it would be kinda appreciated. Let me know, and I can tell you what needs to be done. Otherwise we will get to it when there is a bit of time.

I'd like to contribute a patch, but the whole thing with Bugzilla and the correspondent VCS is quite unfamiliar for me. I've tried to come up with some kind of PR (like regularly on GitHub), but haven't figured out how to do the one here. Would you be so kind to point me to some tutorials how should I supposed to contribute a patch? And where/how can I checkout the sources in the first place?

Thanks!

Comment 4

[James Graham [:jgraham]]

There are docs around https://firefox-source-docs.mozilla.org/setup/linux_build.html

If you're familiar with git you can use that; the first steps are:

curl https://hg.mozilla.org/mozilla-central/raw-file/default/python/mozboot/bin/bootstrap.py -O
python3 bootstrap.py --vcs=git

That should clone mozilla-central and set you up for development. To actually submit a patch you need to use phabricator; https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html has some docs on that but honestly I don't know quite what's up to date here.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hi Kai. I wanted to follow-up on your question and the reply from James. Would you still be interested to work on this particular dependency update?

Comment 6

[Kai Ren]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #5)

Hi Kai. I wanted to follow-up on your question and the reply from James. Would you still be interested to work on this particular dependency update?

Yup, I'll try to submit a PR in next few days!

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Kai Ren from comment #6)

Yup, I'll try to submit a PR in next few days!

Just wanted to ask if further help is necessary. If yes, please let us know! Thanks.

Comment 8

[Jon Gjengset]

Attachment: Bug 1710421 - [webdriver] Update time and cookie dependencies. r?#webdriver-reviewers

This patch updates the time and cookie dependencies of the webdriver crate,
which are currently quite outdated. These two are of particular importance
since they apply even when the server features aren't enabled, and thus carry
over into any consuming crate that uses the webdriver crate solely for client
purposes.

Comment 9

[Jon Gjengset]

Attachment: Bug 1710421 - [webdriver] Update time and cookie dependencies.

This patch updates the time and cookie dependencies of the webdriver crate,
which are currently quite outdated. These two are of particular importance
since they apply even when the server features aren't enabled, and thus carry
over into any consuming crate that uses the webdriver crate solely for client
purposes.

Note that there are now two versions of time in the dependency closure since we
have a lot of other outdated dependencies throughout the tree that bring in
the old version of that crate.

Comment 10

[Jon Gjengset]

Apologies — I couldn't figure out how to rebase my patch without adding extra unnecessary merge commits in it, so I opted to make a new patch instead: https://phabricator.services.mozilla.com/D147000

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:whimboo, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #11)

Redirect a needinfo that is pending on an inactive user to the triage owner.

No action needed here. Jon is now working on this particular bug for both upgrading time and cookies.

Comment 13

[Mike Hommey [:glandium]]

Attachment: Bug 1710421 - [webdriver] Update warp and hyper dependencies.

At the same time, update mdns_service to socket2 0.4 to avoid a duplicate.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1739da34411f
[webdriver] Update time and cookie dependencies. r=webdriver-reviewers,glandium,whimboo
https://hg.mozilla.org/integration/autoland/rev/bdd6f29ebeeb
[webdriver] Update warp and hyper dependencies. r=mjf,webdriver-reviewers

Comment 15

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1710421) for causing web-platform failures on context.rs.
Backout link
Push with failures
Failure Log
wpt15 Failure Log
wpt9 Failure Log

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b35aaa56fa54
[webdriver] Update time and cookie dependencies. r=webdriver-reviewers,glandium,whimboo
https://hg.mozilla.org/integration/autoland/rev/33831638ba99
[webdriver] Update warp and hyper dependencies. r=mjf,webdriver-reviewers

Comment 17

[Marian-Vasile Laza]

Backed out 6 changesets (Bug 1772068, Bug 1710421) for causing multiple web-platform failures.
Backout link
Push with failures <--> Wd1
Failure Log
Wdx filter

Also these multiple Btime failures:
cnn-nav <--> Failure log
dom <--> Failure Lpog

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e98a4c114bee
[webdriver] Update time and cookie dependencies. r=webdriver-reviewers,glandium,whimboo
https://hg.mozilla.org/integration/autoland/rev/367918ba3373
[webdriver] Update warp and hyper dependencies. r=mjf,webdriver-reviewers

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06fd001b4785
Bustage fix. CLOSED TREE

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For the tokio, hyper, and warp upgrades we already had bug 1691131, but that one I'm going to dupe now.

Thanks for working on these upgrades!

Comment 22

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/e98a4c114bee
https://hg.mozilla.org/mozilla-central/rev/367918ba3373
https://hg.mozilla.org/mozilla-central/rev/06fd001b4785