Closed Bug 1691131 Opened 3 years ago Closed 2 years ago

Upgrade geckodriver to hyper 0.14, tokio 1.0, warp 0.3

Categories

(Testing :: geckodriver, task, P3)

Product:
Testing
Component:
geckodriver
Version:
Default
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1710421

People

(Reporter: whimboo, Unassigned)

References

Details

Right now we make use of v0.13 of hyper. Since Christmas last year hyper 0.14 is out:

https://seanmonstar.com/post/638320652536922112/hyper-v014

The following features are optional now, and we could exclude those that we don't need:

    http1
    http2
    client
    server

It also supports Tokio 1.0, which we might also want to bump? Not sure if that gives compatibility issues through. James, any thoughts?

Flags: needinfo?(james)

I think it seems like a good idea to update if we can. But I have no idea how painful it will be. I can't see anything else in the tree using tokio 1.0 yet, which is surprising, so there'd also be a cost there. I think we just need to try it and see how bad things are. Presumably we'd also need to update warp in the webdriver crate so the versions match.

Flags: needinfo?(james)

So as long as nothing breaks it sounds like we should just put it into our backlog. Bastien updated hyper the last time to 0.13. So maybe if he is still around and might have interest... just CC'ing him.

Priority: -- → P3
See Also: → 1710421
Summary: Upgrade geckodriver to hyper 0.14 → Upgrade geckodriver to hyper 0.14, tokio 1.0, warp 0.3

(In reply to Dan Minor [:dminor] from bug 1758163 comment #0)

Landing bug 1757407 will result in tokio 1.0 being vendored into the tree, which will be the third copy of tokio. We have https://bugzilla.mozilla.org/show_bug.cgi?id=1697845 to remove the use in audioipc. Updating warp to 0.3.2 should bring in tokio 1.0.0 which should hopefully get us down to one copy of tokio once the audioipc bug is fixed.

Whiteboard: [webdriver:triage]

As discussed in the meeting it's not a priority for us and we are fine with having the older crate releases in the tree. It might be a large amount of work for us while we do not really use the async features.

Whiteboard: [webdriver:triage]

All the upgrades have been done as part of bug 1710421.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.