1710648 - [Phase 2] The QS sponsored URL flickers while typing a keyword if the website was already visited multiple times

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: flicker v2.gif

[Affected versions]:

• Firefox Nightly 90.0a1 (Build ID: 20210511093339);

[Affected Platforms]:

• Windows 10 x64;
• macOS 10.15.7;
• Linux Mint 20 x64;

[Prerequisites]:

• Have the latest Firefox Nightly installed.
• Have the following prefs set:
• browser.urlbar.quicksuggest.enabled to true.
• browser.urlbar.quicksuggest.seenRestarts to '89'.
• browser.urlbar.quicksuggest.showedOnboardingDialog to true.
• browser.urlbar.experimental.firefoxSuggestLabels.enabled totrue`.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to "https://www.amazon.com/" website.
3. Perform 3 different searches.
4. Close the tab and open a new one.
5. Start typing "amazon prime" in the Awesomebar.
6. Delete one character at a time and observe the QS displayed while typing.

[Expected result]:

• There is no flicker while typing the keyword.

[Actual result]:

• The QS sponsored URL flickers while typing the keyword.

[Notes]:

• Attached a screen recording of the issue.
• The issue is also reproducible if the "Show search suggestions ahead of browsing history in address bar results" option is unchecked.
• We had this issue in the past and was fixed, however, it seems that now is reproducible. Here is the old bug: Bug 1698496.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1710648 - Prevent quick suggest results from flickering now that they don't have a suggestedIndex.

This extends the flicker-protection logic for suggested-index results to quick
suggest results. This is a narrow fix for the bug, and I've added the same TODO
that I added to the muxer in bug 1709992 D114669.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c6408a83d8dab0bf38b243624f9349aaa51c89e

Comment 3

[Drew Willcoxon :adw]

Cosmin, so we can speed this up, could you please test the builds in the link in comment 2? They should fix bug 1710657 too.

Comment 4

[Drew Willcoxon :adw]

(In reply to Drew Willcoxon :adw from comment #3)

Cosmin, so we can speed this up

Just to be clear, I mean that if you have time, it would be nice to verify that the patch fixes flickering for you before we land it. We've gone through several of these flicker bugs before where I land a fix but it turns out it didn't fix some other case or caused new flicker, so we have to file new bugs and make new patches, which is a pain especially around uplift. Of course I'm trying to test as much as I can, but I often miss things.

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi @Drew! I have verified this bug using the Nightly try build from comment 2. The flickering issue and Bug 1710657 are no longer reproducible with this build.

• I have verified these scenarios on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04. I have also performed exploratory testing and I haven't encountered any new issues.

I will perform another round of testing as soon as the patch lands on Nighty.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55581a0b936e
Prevent quick suggest results from flickering now that they don't have a suggestedIndex. r=mak

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/55581a0b936e

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 90.0a1 build (Build ID: 20210513093303) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04.

• The issue is no longer reproducible with the latest Nightly build.
• Also the behavior described in Bug 1710657 is no longer reproducible.

Comment 9

[Drew Willcoxon :adw]

Comment on attachment 9221426 [details]
Bug 1710648 - Prevent quick suggest results from flickering now that they don't have a suggestedIndex.

Beta/Release Uplift Approval Request

• User impact if declined: This will allow us to roll out phase 2 of Firefox Suggest to all en-US users on 89, not only those who have "Show search suggestions ahead of bookmarks and history" checked (the default). Without this, we'll have to wait until 90 to roll out phase 2 for users who have unchecked that preference. That would probably be OK, so this is more of a nice to have.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see earlier comments in this bug (should be clear)
• List of other uplifts needed: Bug 1709992
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a targeted patch that only affects quick suggest results, which will only be enabled in phase 2 of the Firefox Suggest rollout.
• String changes made/needed:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9221426 [details]
Bug 1710648 - Prevent quick suggest results from flickering now that they don't have a suggestedIndex.

Approved for 89.0b13.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/96d562f74d89

Comment 12

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 89.0b13 on Windows 10 x64, macOS 10.15.7 and Linux Mint 20.

• The issue is not reproducible with the latest Beta 89.0b13.