Closed Bug 1710933 Opened 1 month ago Closed 8 days ago

LaunchWithApplication download should be moved to the "Downloads" folder when finished

Categories

(Firefox :: Downloads Panel, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: mtigley, Assigned: ava8katushka)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Currently, a download through LaunchWithApplication ("Open with Foo application") is initially created in the temp directory and is removed when the last session is closed.

We want to change it so that when the download is finished, it's moved to the "Downloads" folder (and is not deleted when the last session closes).

Edit: It's not clear why the downloaded file needs to saved to the /temp directory first and then moved to the Downloads folder. Instead, this issue will save launched-with-app downloads directly to the Downloads folder.

Severity: -- → S3
Priority: -- → P3
Summary: LaunchWithApplication download should be moved to the Download → LaunchWithApplication download should be moved to the "Downloads" folder when finished
Assignee: nobody → ava8katushka
Status: NEW → ASSIGNED
Blocks: 1714107

Hi, Micah/Ava.

I know you're not working strictly in this but: could it be possible to review the current behavior of saving downloaded files to a /tmp folder before moving it to Downloads, and change that to save to Downloads directly? There have been lots of bugs filled about the current behavior (see Downloads are stored in $TMPDIR|$TMP|$TEMP|/tmp first and then moved to the selected path only after the download finishes / location is selected (closed) and Change nsSpecialSystemDirectory::operator=(OS_TemporaryDirectory) to violate FHS (open)).

As an Ubuntu (Linux) user I'm constantly seing warnings about programs not being able to open /tmp files because of permissions restrictions. For example, you can't use LibreOffice snap (an Ubuntu containareizad-app format) to open a file choosing the "Open with" option because it will always fail (there has been a debate about this here: Sharing files via /tmp).

(In reply to Santiago Fernández Núñez from comment #2)

could it be possible to review the current behavior of saving downloaded files to a /tmp folder before moving it to Downloads, and change that to save to Downloads directly?

The work Ava has done in https://phabricator.services.mozilla.com/D115997 actually makes it so downloaded files are directly saved to the Downloads folder when the pref browser.download.improvements_to_download_panel is enabled .
There wasn't a clear reason why it needs to be saved to the temporary directory and then moved to Downloads, which was briefly brought up here. I'll need to update the original comment to clarify this.

(In reply to Micah Tigley [:mtigley] from comment #3)

Great to hear this, I wasn't aware of this job! Thanks!

Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dafe8426eac5
Save LaunchWithApplication downloads into downloads folder for windows and unix r=mtigley
Status: ASSIGNED → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.