1710936 - about:welcome should not offer to set the default browser if browser.shell.checkDefaultBrowser is false

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P2)

Description

[Mike Kaply [:mkaply]]

We have partners that either can't set the browser as default or don't want to have set the browser as default (for contractual reasons).

So we have the pref:

browser.shell.checkDefaultBrowser

to prevent the browser from checking if it's the default browser (should stop the popup and the infobar).

I believe we should not offer to set the default on firstrun if this is set as well.

Comment 1

[Ed Lee :Mardak]

Bug 1691145 made the initial welcome screen show "Make Default" and a related bug 1701873 wanted the initial message to be different if already default.

How would browser.shell.checkDefaultBrowser be set on a new profile?

Comment 2

[Mike Kaply [:mkaply]]

It's set via distribution.ini which is in the distribution directory where Firefox is installed.

https://github.com/mozilla-partners/canonical/blob/master/desktop/ubuntu/distribution/distribution.ini

Comment 3

[Ed Lee :Mardak]

Thanks. I do see that on a brand new profile on ubuntu. Some reason my existing profile did have the user pref flipped to true although it did know the distribution-set-default was false. And just to confirm about:support distribution id shows "canonical" for me.

Comment 4

[Punam Dahiya [:pdahiya]]

NI Ed to help triage and recommend next steps.

Comment 5

[Ed Lee :Mardak]

Looking at what we had before the first screen asked about default, it used

onboarding-multistage-welcome-header = Welcome to <span data-l10n-name="zap">{ -brand-short-name }</span>
onboarding-multistage-welcome-subtitle = The fast, safe, and private browser that’s backed by a non-profit.
onboarding-multistage-welcome-primary-button-label = Start Setup

So with the new MR1 about:welcome, I guess we could keep the MR1 text and replace the primary button and remove the secondary/not now from prepareContentForReact… but only if it's on the first screen? We wouldn't want some experiment with a later default button to then show "Start Setup" on potentially the last screen.

Probably should check how the buttons should be placed as the MR1 design initial screen assumed a primary and secondary button for layout.

Comment 6

[Ed Lee :Mardak]

As part of bug 1712802 for showing different initial screen text/button, there are designs for if Firefox is already default or in the case of this bug shouldn't ask to be set as default. Currently the design says…

Welcome to Firefox
[Get started]

https://www.figma.com/file/0awIRES0ZvRJ1U89fYPXjQ/MR1-Onboarding?node-id=2586%3A1763

Comment 7

[Ed Lee :Mardak]

This should be fixed by bug 1712802
https://hg.mozilla.org/mozilla-central/rev/1bb1cb8c82ff

Comment 8

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (90.0b1 Build ID - 20210601190019) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20 x64. Now I can confirm that the "Get Started" button is displayed on the first screen of the "about:welcome" page if the browser.shell.checkDefaultBrowser pref is set to false.