1710937 - Remove newtab styles pref

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Amy Churchwell [:amy]]

Remove pref browser.newtabpage.activity-stream.newNewtabExperience.enabled

Comment 1

[Harry Twyford]

Attachment: Bug 1710937 - Part 1 - Remove newNewTabExperienceEnabled pref and associated code. r?amy!

Comment 2

[Harry Twyford]

Attachment: Bug 1710937 - Part 2 - Remove showCustomizationMenu pref and associated code. r?amy!

Depends on D123248

Comment 3

[Harry Twyford]

Attachment: Bug 1710937 - Part 3 - Remove tests concerning the differences between old-new-tab and new-new-tab. r?amy!

Depends on D123249

Comment 4

[Harry Twyford]

Attachment: Bug 1710937 - Part 4 - Remove SectionMenus and section header icons. r?amy!

Depends on D123250

Comment 5

[Harry Twyford]

Attachment: Bug 1710937 - Part 5 - Remove tests related to context menu icons and clicking section headers. r?amy!

Depends on D123251

Comment 6

[Harry Twyford]

Attachment: Bug 1710937 - Part 6 - Remove code related to showing fallback screenshots in Top Sites. r?amy!

I confirmed with Julian Gaibler that we don't want to show screenshots as fallbacks in Top Sites. We still want to support custom icons and screenshots in the "Recent activity" section, both of which are unchanged.

Depends on D123252

Comment 7

[Harry Twyford]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d787cf25f60446be6135b69d9abf59ad1391e11b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/124360892961
Part 1 - Remove newNewTabExperienceEnabled pref and associated code. r=amy,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/72cd0db4013b
Part 2 - Remove showCustomizationMenu pref and associated code. r=amy
https://hg.mozilla.org/integration/autoland/rev/33f654138ed7
Part 3 - Remove tests concerning the differences between old-new-tab and new-new-tab. r=amy
https://hg.mozilla.org/integration/autoland/rev/80316c317bab
Part 4 - Remove SectionMenus and section header icons. r=amy
https://hg.mozilla.org/integration/autoland/rev/11acc8283bba
Part 5 - Remove tests related to context menu icons and clicking section headers. r=amy
https://hg.mozilla.org/integration/autoland/rev/51472931ad65
Part 6 - Remove code related to showing fallback screenshots in Top Sites. r=amy

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/124360892961
https://hg.mozilla.org/mozilla-central/rev/72cd0db4013b
https://hg.mozilla.org/mozilla-central/rev/33f654138ed7
https://hg.mozilla.org/mozilla-central/rev/80316c317bab
https://hg.mozilla.org/mozilla-central/rev/11acc8283bba
https://hg.mozilla.org/mozilla-central/rev/51472931ad65

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the browser.newtabpage.activity-stream.newNewtabExperience.enabled pref is no longer displayed in the "about:config" page.

Verified using the latest Firefox Nightly (94.0a1 Build ID - 20210923214525) installed on Windows 10 x64, macOS 11.6, and Linux Mint 20 x64.