1711274 - Connections Settings subdialog doesn't disable fields when radio selection changes

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Alessandro Castellani [:aleca]]

To reproduce

• Access Preferences > General > Connection area > Settings... button.
• Change the Proxies radio button between Manual and other options.

The input fields that "belongs" to the Manual radio option should be disabled when that option is not selected.

This happens correctly in Firefox.
I'm not sure if this bug should be here or in the upstream synchronization.

Comment 1

[Magnus Melin [:mkmelin]]

Need to port https://searchfox.org/mozilla-central/rev/6bb805571d6036bdd24d8e26511e55b2c4f5d0f8/browser/components/preferences/dialogs/connection.js#384 - bug 1429593 - https://hg.mozilla.org/mozilla-central/rev/bb1b856328ab

John, is proxying enabled for add-ons? If it is, we should port all of the above diff.

Comment 2

[Lasana Murray]

This patch is from 2018, seems like a lot has changed mainly xul -> xhtml, stringbundle -> fluent and some subsequent bug fixes. How should I approach this?

Comment 3

[John Bieling (:TbSync)]

I was looking at proxy support in WebExtensions and browser.proxy seems to be available, but I have never used it yet. I run the tests in toolkit and the ones related to proxy seem to pass. So from that I think proxy is enabled for add-ons.

Comment 4

[Magnus Melin [:mkmelin]]

I think we've mainly kept up with the change. The updateProxySettingsUI call is basically what's needed I think, but we should add the info about proxies too in case that comes up. So, copy as much of the original patch as need and adjust for whatever other changes have been done since.
For semi-shared UI like this we try to keep the function names and such the same as the corresponding Firefox ones.

Comment 5

[Lasana Murray]

Attachment: Bug 1711274 - Port bug 1429593, restore manual proxy controls disabling. r?mkmelin

This also includes some changes from bug 1505330 and bug 1557754.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb49d22d1742
Port bug 1429593, restore manual proxy controls disabling. r=mkmelin