1728323 - Follow-up of bug 1711274: Missing fluent translations and other porting issues

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Bug 1711274 ported extensionControlled.js from mozilla-central into comm-central, but it has a few problems:

• It contains dictionary objects (https://searchfox.org/comm-central/rev/2b9757e10d3304dbb539a4b3fdded6699db54b20/mail/components/preferences/extensionControlled.js#58-79), but I think only the proxy.settings entry is actually used. The unused entries should be removed. If there is only one used entry, some of the methods that use these dictionaries could be made specific to this setting, which would make the code less convoluted.
• initListenersForPrefChange is defined but unused. It should be removed.
• We are missing fluent entries for at least extension-controlled-proxy-config and extension-controlled-enable.
• We are missing the image source "chrome://browser/skin/menu.svg".
• showEnableExtensionMessage uses xul elements in a semantically incorrect way (e.g., a xul:image is used as a close button, and a xul:label is used to display a message). We should probably change this to html as well. Note: this is inherited from mozilla-central.
• There are html:img elements with no alt attribute, or some accessible name. Note: this is also inherited from mozilla-central.

Comment 1

[Richard Marti (:Paenglab)]

(In reply to Henry Wilkes [:henry] from comment #0)

• We are missing the image source "chrome://browser/skin/menu.svg".

We can use "chrome://messenger/skin/icons/appbutton.svg" instead.

Comment 2

[Wayne Mery (:wsmwk)]

This affects v91?

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

(In reply to Wayne Mery (:wsmwk) from comment #2)

This affects v91?

I think so. Bug 1711274 caused this, and it has a target milestone of 91. I'm not sure what the proper way to check is, but the changes are part of 91 Beta, e.g. https://hg.mozilla.org/comm-central/file/BETA_91_BASE/mail/components/preferences/extensionControlled.js

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Bug 1728323 - Simplify extensionControlled and add missing fluent translation. r=mkmelin

We were missing lots of fluent ids that the previous code would have needed.

We only have extension control for proxy.settings, so this was simplified.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3cb7432dd334
Simplify extensionControlled and add missing fluent translation. r=mkmelin

Comment 6

[Henry Wilkes (they/them) [:henry-x]]

Introduces new strings, so can't fix for 91.