Closed
Bug 1711463
Opened 4 years ago
Closed 4 years ago
Update EvaluationContextSelector on DOCUMENT_EVENT
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox90 fixed)
RESOLVED
FIXED
90 Branch
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In Bug 1704458 , we'll update targetFront title
and url
properties when receiving DOCUMENT_EVENT
resources.
Since those are attributes we're using in the context selector to render the list of targets, we should re-render the list when receiving DOCUMENT_EVENT
resources.
Assignee | ||
Comment 1•4 years ago
|
||
This patch adds a refreshTargets
action that is called from the toolbox when
a dom-interactive DOCUMENT_EVENT is received.
This action will only update a new state property, lastTargetRefresh
, with the
current timestamp, so the EvaluationContextSelector
component will re-render;
as the target information are directly retrieved from the target fronts, any
changes in the title/url will be shown in the component.
Depends on D114601
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f42d01c0ec3
[devtools] Update EvaluationContextSelector items on DOCUMENT_EVENT resources. r=jdescottes.
Backout by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff72ff2eabd7
Backed out 5 changesets (bug 1711463, bug 1691577, bug 1691576, bug 1704458) for failures on browser_target_list_frames.js. CLOSED TREE
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•