Fix and re-enable devtools/client/framework/test/browser_toolbox_window_title_changes.js test for Fission
Categories
(DevTools :: Framework, task, P3)
Tracking
(Fission Milestone:M7a, firefox90 fixed)
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: cpeterson, Assigned: nchevobbe)
References
(Blocks 2 open bugs)
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file, 2 obsolete files)
This test was disabled for Fission in bug 1566182.
[browser_toolbox_window_title_changes.js]
skip-if = fission
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
The test is failing on fission because the devtools window title (when undocked), isn't updated when a target switch occurs.
We do update the title when we receive the navigate
event for a given target (https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/framework/toolbox.js#701), but in the case of a target switch, we don't receive it, and as a result we don't change the title.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Note that we'll probably have to switch from the navigate
event to listen for DOCUMENT_EVENT
resource
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 4•3 years ago
|
||
Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.
Updated•3 years ago
|
Comment 6•2 years ago
|
||
This helps fix browser_toolbox_window_title_changes.js
Comment 7•2 years ago
|
||
Nicolas, do not hesitate to fold this patch into yours. The test cleanup are valuable!
It is better to rely on DOCUMENT_EVENT instead of onTargetAvailable as the title won't always be already defined when the target just started loading.
And using DOCUMENT_EVENT also aligns well with the other patch I submitted to bug 1704458.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 8•2 years ago
|
||
Depends on D104540
Updated•2 years ago
|
Updated•2 years ago
|
Comment 9•2 years ago
|
||
Comment on attachment 9220812 [details]
Bug 1691576 - [devtools] Update targetFront url and title on DOCUMENT_EVENT resource. r=ochameau,jdescottes.
Revision D114601 was moved to bug 1704458. Setting attachment 9220812 [details] to obsolete.
Comment 10•2 years ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4be8b7f7783 [devtools] Update DevTools window title on DOCUMENT_EVENT resource. r=ochameau.
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Backed out along with Bug 1704458 and Bug 1691577.
Comment 12•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•