1691576 - Fix and re-enable devtools/client/framework/test/browser_toolbox_window_title_changes.js test for Fission

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Chris Peterson [:cpeterson]]

This test was disabled for Fission in bug 1566182.

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/framework/test/browser.ini#153-154

[browser_toolbox_window_title_changes.js]
skip-if = fission

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

The test is failing on fission because the devtools window title (when undocked), isn't updated when a target switch occurs.
We do update the title when we receive the navigate event for a given target (https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/devtools/client/framework/toolbox.js#701), but in the case of a target switch, we don't receive it, and as a result we don't change the title.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1691576 - [devtools] Update DevTools window title on DOCUMENT_EVENT resource. r=ochameau.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Note that we'll probably have to switch from the navigate event to listen for DOCUMENT_EVENT resource

Comment 4

[Chris Peterson [:cpeterson]]

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1691576 - [devtools] Listen to DOCUMENT_EVENT's dom-complete instead of target's navigate in toolbox.js

This helps fix browser_toolbox_window_title_changes.js

Comment 7

[Alexandre Poirot [:ochameau]]

Nicolas, do not hesitate to fold this patch into yours. The test cleanup are valuable!
It is better to rely on DOCUMENT_EVENT instead of onTargetAvailable as the title won't always be already defined when the target just started loading.
And using DOCUMENT_EVENT also aligns well with the other patch I submitted to bug 1704458.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1691576 - [devtools] Update targetFront url and title on DOCUMENT_EVENT resource. r=ochameau,jdescottes.

Depends on D104540

Comment 9

[Phabricator Automation]

Comment on attachment 9220812 [details]
Bug 1691576 - [devtools] Update targetFront url and title on DOCUMENT_EVENT resource. r=ochameau,jdescottes.

Revision D114601 was moved to bug 1704458. Setting attachment 9220812 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4be8b7f7783
[devtools] Update DevTools window title on DOCUMENT_EVENT resource. r=ochameau.

Comment 11

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1704458 and Bug 1691577.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1704458#c8

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5212393f6266