Closed
Bug 1711519
Opened 3 years ago
Closed 3 years ago
Remove gProton use from frontend code
Categories
(Firefox :: Toolbars and Customization, task, P3)
Tracking
()
RESOLVED
FIXED
91 Branch
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
(Whiteboard: [proton-cleanups])
Attachments
(3 files)
+++ This bug was initially created as a clone of Bug #1711515 +++
(As noted in bug 1709425, we should not land a patch for this before May 20th. Patches in bug 1711500, to tests that read this pref, will need to land first)
All of these checks are redundant with proton enabled by default. We should remove the checks, and remove code that only runs if this getter returns false. We should leave the getter itself in browser.js for now.
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1771
|
||
Updated•3 years ago
|
Priority: -- → P3
|
||
Updated•3 years ago
|
Severity: -- → N/A
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D116630
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D116631
|
||
Updated•3 years ago
|
Attachment #9224774 -
Attachment description: WIP: Bug 1711519 - remove trivial gProton and gProtonDoorhangers checks, r?jaws → Bug 1711519 - remove trivial gProton and gProtonDoorhangers checks, r?jaws
|
|
||
Updated•3 years ago
|
Attachment #9224776 -
Attachment description: WIP: Bug 1711519 - remove non-proton notificationbox code and remove conditionals for proton, r?mstriemer → Bug 1711519 - remove non-proton notificationbox code and remove conditionals for proton, r?mstriemer
|
|
||
Updated•3 years ago
|
Attachment #9224777 -
Attachment description: WIP: Bug 1711519 - remove tabbrowser non-proton code and gProton global browser window property, r?jaws → Bug 1711519 - remove tabbrowser non-proton code and gProton global browser window property, r?jaws
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/99247c954e44 remove trivial gProton and gProtonDoorhangers checks, r=jaws https://hg.mozilla.org/integration/autoland/rev/48a2313aad76 remove non-proton notificationbox code and remove conditionals for proton, r=jaws https://hg.mozilla.org/integration/autoland/rev/6ad04d522474 remove tabbrowser non-proton code and gProton global browser window property, r=jaws
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/99247c954e44
https://hg.mozilla.org/mozilla-central/rev/48a2313aad76
https://hg.mozilla.org/mozilla-central/rev/6ad04d522474
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
|
||
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•