1713083 - Remove JSPROP_GETTER and JSPROP_SETTER

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jan de Mooij [:jandem]]

After bug 1700958 and bug 1712764 it's now possible to remove the remaining uses of these flags.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1713083 part 1 - Stop using JSPROP_GETTER and JSPROP_SETTER to distinguish native vs self-hosted JSPropertySpec accessors. r?evilpie!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1713083 part 2 - Remove JSPROP_GETTER and JSPROP_SETTER. r?evilpie!

We now set the descriptor's getter or setter when the corresponding argument
to DefineAccessorProperty is non-nullptr.

Usually the flag was passed only if the corresponding object argument was non-nullptr,
so there's no change in behavior for those.

The excepetion is Console::PopulateConsoleNotificationInTheTargetScope where we passed
JSPROP_SETTER with a nullptr setter. Changing this is likely okay; it shouldn't make a
difference for new properties anyway.

Note that code can still use the richer PropertyDescriptor API to set nullptr
getters/setters explicitly.

Depends on D116090

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78f310c584d9
part 1 - Stop using JSPROP_GETTER and JSPROP_SETTER to distinguish native vs self-hosted JSPropertySpec accessors. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/cb3b1b908391
part 2 - Remove JSPROP_GETTER and JSPROP_SETTER. r=evilpie

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/78f310c584d9
https://hg.mozilla.org/mozilla-central/rev/cb3b1b908391