1713678 - Use DOCUMENT_EVENT's will-navigate event to track navigation in toolbox.js

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Toolbox module is still listening to target actor's will-navigate which doesn't fire when switching between two JSWindowActor based target and so it break with bfcache navigation and server side target switching.

This code:
https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#701
should instead use DOCUMENT_EVENT will-navigate to track navigation.

Comment 1

[Alexandre Poirot [:ochameau]]

This is involved into devtools/client/inspector/test/browser_inspector_select-last-selected.js failure with bfcache in parent (in addition to bug 1710582)

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1713678 - [devtools] Use DOCUMENT_EVENT will-navigate in toolbox.

This helps clear various things for all navigations, including the cross process navigation
and navigation with JSWindowActor based targets.
With work from bug 1702511, this also helps clearing at the precise right time.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0b46be5870b
[devtools] Use DOCUMENT_EVENT will-navigate in toolbox. r=nchevobbe,jdescottes

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c0b46be5870b