1713784 - Implement basic support for session.new command (without capability matching)

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For direct BiDi connections the session.new() command needs to be implemented, which isn't fully specified yet. See https://github.com/w3c/webdriver-bidi/issues/97

For it's implementation we would also have to add full capability matching for firstMatch and alwaysMatch. Currently this is only implemented in the geckodriver and webdriver crates.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For the demo we don't need the capability matching. I'll file a new bug for that.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1713784 - [remote] Implement basic support for session.new command.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is just a WIP and has to wait until the WebDriver BiDi spec has been updated. As such unassigning myself for now.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Bug 1720707 will not block us to get this feature landing.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Even bug 1693838 can be removed from the dependency list because this command will have no payload for the initial landing.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't want to cause merge conflicts for Julian over on bug 1713439. As such the review will be deferred until the other bug has been fixed.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Chatted with Julian, and he actually based his work on this WIP. As such we agreed on to get this landed first even not yet part of the spec.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1713784 - [remote] Implement "sendError" for WebDriverBiDi connection.

Depends on D120303

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b651fb27cbba
[remote] Implement "sendError" for WebDriverBiDi connection. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/2fd613c3d66e
[remote] Implement basic support for session.new command. r=webdriver-reviewers,jdescottes,jgraham

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b651fb27cbba
https://hg.mozilla.org/mozilla-central/rev/2fd613c3d66e