1693838 - Add support for command's payload deserialization

Status: RESOLVED INACTIVE

(Remote Protocol :: WebDriver BiDi, task)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When receiving commands the contained payload needs to be deserialized. We should get the basics implemented so that the logging feature can be implemented.

It would be good to know which commands would be necessary, and as such which data types are required.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For the next milestone 2 we might want to have more than just basic support. Updating the summary for now, triage will happen early in September.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This bug might not be needed for milestone 2 given that none of the commands that we need (session.subscribe, session.unsubscribe, browsingContext.navigate) actually have complex data types. I would propose P3.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Talked with Julian, and we want to first introduce generic code for serialization / deserialization over on bug 1693839. Then we will follow-up with new bugs for specific data types. As such duping this bug to bug 1693839.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We actually had to drop deserialization from bug 1693839 because it's not yet defined in the BiDi spec.

Note that with the upcoming https://github.com/w3c/webdriver-bidi/pull/142 there will not only be primitive values and these which need an objectId, but also those that should be deserializable even without such an objectId. This would apply to the following local values:

LocalValue = {
PrimitiveProtocolValue //
ArrayLocalValue //
DateLocalValue //
MapLocalValue //
ObjectLocalValue //
RegExpLocalValue //
SetLocalValue //
}

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Both session.subscribe and session.unsubscribe don't need this feature.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Basic support we will get via bug 1739976.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We will have different bugs for the implementation instead:

1. Ownership model with strong handle reference (bug 1770736)
2. Complex objects with simple value fields (bug 1770751)
3. Complex objects with container value field (bug 1770780)

Closing this bug in favor of the others.