1716295 - Tooltips from title attribute do not show in popups or extension tabs/windows

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Teal Dulcet [:tdulcet] (TB Council)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

1. Create a simple MailExtension with a browserAction and/or composeAction popup that has an element with the HTML title attribute.
2. Hover over that element.

Actual results:

Nothing happens (see below)

Expected results:

The tooltip should show. I tested in both Thunderbird 78.11 and 90 beta.

In TB 78, tooltips do not show in composeAction popups. In TB 90 beta, they do not show in both browserAction and composeAction popups.

Comment 1

[tobias.bengfort]

Not sure if this is the same issue: When I use browser.tabs.create() with an URL to an HTML file that is included with my extension, I do not get tooltips either.

Comment 2

[Teal Dulcet [:tdulcet] (TB Council)]

Attachment: action_popups.zip

Here is an minimal example extension to reproduce the issue, adapted from https://github.com/HiraokaHyperTools/ActionPopupTest.

Reproducible in TB 91 and 97 beta with all three action popups.

Comment 3

[Alexander Bergmann]

Originally I was going to enhance the buttons in the popup windows of my add-on Mail Merge with tooltips via the title attribute. But then I discovered this very bug using Thunderbird 102.6.1.

I run a bisection with mozregression-gui with the following result: Daily 86.0a1 (2021-01-19) (64-bit) was the last known good build and Daily 86.0a1 (2021-01-20) (64-bit) was the first known bad build. The pushlog is here:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=103dddc019f7cbb7046aa6ab4b09499944c05472&tochange=be365d09c14b55f717bdf633cf48dbb6a27a3754

The problem seems to be caused by enabling e10s back then. Disabling e10s via browser.tabs.remote.autostart = false makes the tooltip work again - even in the current stable Thunderbird 102.6.1.

In Firefox 108 the tooltip is working - even if e10s is enabled (the default). So the problem seems to be Thunderbird specific.

Comment 4

[Alexander Bergmann]

I had the idea, that - maybe - Firefox was affected by this regression in the past as well. And indeed Nightly 2016-09-22 was broken and Nightly 2016-09-23 fixed the bug. For the test in Firefox it was necessary to enable e12s manually via browser.tabs.remote.autostart =true, because e10s was not enabled by default back then.

Here is the pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f0e6cc6360213ba21fd98c887b55fce5c680df68&tochange=052d4d77cbcae9d168754a62e6f71fd9946743b0

This changeset looks like the bugfix in Firefox:

5da51b708f74499c4172e17b973caa9a6c3a307d Tomislav Jovanovic - bug 1269421 - enable HTML tooltips in extension popups

Bug 1269421 describes the very same problem for Firefox and the attached "Minimal test extension" also triggers the very same problem in Thunderbird. I hope the applied fix for Firefox can be easily ported to Thunderbird, so we can have tooltips in due time.

Comment 5

[John Bieling (:TbSync)]

Thanks Alexander. I am going to check this.

Comment 6

[John Bieling (:TbSync)]

Tracked it down to this line being executed, but nothing happens:
https://searchfox.org/mozilla-central/rev/d39a17381a14606032f7b8e82789bf281beb1241/docshell/base/nsDocShellTreeOwner.cpp#1338

The attribute is already set for the action popup and was not set for the window popup (missing in extensionsPopup.xhtml), but adding it did not make a difference.

Comment 7

[John Bieling (:TbSync)]

Found it!

Comment 8

[John Bieling (:TbSync)]

Attachment: Bug 1716295 - Fix missing tooltips in action popups, window popups and content tabs. r=darktrojan

Comment 9

[John Bieling (:TbSync)]

try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=86734a6ae256a6f2599b8af99ae6386226f1ad19

I do not see new fails compared to this try without this patch:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=4c0d2b7ee1e85b5023828b9c82346bd3a9aa375e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d3155a0bbcf
Fix missing tooltips in action popups, window popups and content tabs. r=darktrojan

Comment 11

[John Bieling (:TbSync)]

As pointed out by @myaddons, this is still not fixed in compose action popups. The next patch should therefore also include a test to make sure we did not forget something.

Comment 12

[John Bieling (:TbSync)]

Attachment: Bug 1716295 - Fix tooltips of action popups in the compose window and in the message window. r=darktrojan

Depends on D179638

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e4aa2eac3d13
Fix tooltips of action popups in the compose window and in the message window. r=darktrojan

Comment 14

[John Bieling (:TbSync)]

Comment on attachment 9336938 [details]
Bug 1716295 - Fix tooltips of action popups in the compose window and in the message window. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
The tooltip will not work in compose action popups and message windows.

Testing completed (on c-c, etc.):
Just landed, but tested thoroughly.

Risk to taking this patch (and alternatives if risky):
None that I am aware of.

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9336938 [details]
Bug 1716295 - Fix tooltips of action popups in the compose window and in the message window. r=darktrojan

[Triage Comment]
Approved for beta

Comment 16

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/b05d7be193b0