171711 - Delete in standalone window only works once

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Mike Pinkerton (not reading bugmail)]

- open mail in standalone window
- click delete (it'll delete and advance to next message)
- click delete again

expected:
- second message deleted

actual:
- nothing happens

you have to close the standalone window and open it again for delete to work,
and then it'll only work once.

build from 9/29/02, macosx

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

I see this as well with build 2002-09-30-10 on Windows 2000, IMAP.

I enabled JS dumps, strict warnings (both in chrome and web content), and
nothing stands out.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

keyword lovin' - regression and nsbeta1

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Pink, care if I dup this to bug 90539?  Looks like that bug at least has a TM.

Comment 4

[scottputterman]

90539 could be similar, but I'm not sure since that mentions the delete key only
and it's old.  This is definitely with the delete toolbar button.  We should try
to fix this asap.  If this is happening in 90539 then this is probably happening
on the branch. Stephen, can you see if the latest branch build has this problem,
too?

Comment 5

[jglick]

Using 2002092010, windows trunk, i am seeing this too. Noticed it in the last 
couple of trunk builds.

Could bug 27417 (When tree item deleted, next item should be selected(selection 
should not be destroyed)) be at all related? Since once the first msg is 
deleted, the 2nd msg (the one now being displayed in standalone) is no longer 
selected in 3 pane?

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Scott, Delete using the toolbar button on the branch's Windows 2000 build with
the 'Move message to Trash' IMAP delete model works fine with the 30th build.

Comment 7

[scottputterman]

thanks for looking at that Stephen.  So, this is most likely a pretty new bug.

Comment 8

[David :Bienvenu]

taking - I'm strongly suspect I sr'ed the change that caused this.

Comment 9

[David :Bienvenu]

 -> Navin

OK, I suck - I should really have insisted on my objections to the patch that
caused this.

the problem is that in the standalone window, m_deletingRows is never cleared in
the stand-alone msg window view, so subsequent deletes won't ever work.

Comment 10

[Navin Gupta]

Attachment: proposed fix

The fix is to call nsMsgDBView::OnDeleteCompleted for messageWindow just like
we do for 3 pane and also check for mTreeSelection in OnDeleteCompleted because
stand alone window will have mTreeSelection as null.

Comment 11

[Navin Gupta]

cavin, bienvenu, reviews? thx. 

Comment 12

[Cavin Song]

Comment on attachment 101186 [details] [diff] [review]
proposed fix

r=cavin.

Comment 13

[Navin Gupta]

Attachment: proposed fix, v2

missed out failure case in the last patch.

Comment 14

[Navin Gupta]

Attachment: proposed fix, v2

missed out failure case in the last patch.

Comment 15

[Navin Gupta]

Comment on attachment 101192 [details] [diff] [review]
proposed fix, v2

wrong patch.

Comment 16

[David :Bienvenu]

Comment on attachment 101193 [details] [diff] [review]
proposed fix, v2

sr=bienvenu

Comment 17

[Navin Gupta]

fixed

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with the 2002-10-01-08 builds on:

Mac OS X 10.1.5, Windows 2000 and RedHat 8.0 Linux.

Tested:

POP3 - works fine.
IMAP - 'Mark as Deleted', 'Move it to the Trash folder' and 'Remove it
immediately' delete models.

Note that 'Mark as Deleted' doesn't advance to the next message after a mark,
but that's bug 150462.  Both 'Move it to the Trash folder' and 'Remove it
immediately' work as expected now with IMAP.

Verified FIXED

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 171067 has been marked as a duplicate of this bug. ***