1717223 - Empty inline content when a vcard with multiple contacts is attached.

Status: NEW

(Thunderbird :: Message Reader UI, defect)

Description

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Demo email with x-vcard attachment with multiple contacts

Steps to Reproduce

Open an email with a text/x-vcard attachment that contains more than one contact. i.e. more than one BEGIN:VCARD ... END:VCARD. Make sure "Display attachments inline" is checked. I've attached an .eml file with such an attachment which you can open with thunderbird or mach run as a command line argument.

Note, once Bug 1667716 patch https://phabricator.services.mozilla.com/D118268 lands, an attachment with text/vcard content will also work. In which case you can create the email in Thunderbird (which exports text/vcard content).

Result

The email only shows the message content, but nothing from the attachment inline. Moreover, the email looks like it has no attachments.

Expect

Either all the contacts in the attachment to be shown inline. Or the attachment should appear as a regular attachment.

Origin

I think this line is the origin of the missing content https://searchfox.org/comm-central/rev/ea1278fae63adcd7fbc22407ff77a9851d38299f/mailnews/addrbook/modules/VCardUtils.jsm#312, which is returned if VCardUtils.vCardToAbCard(data) throws an error. Doing some debugging, there is indeed an error thrown, with the stack:

TypeError: name.replace is not a function
_parse@resource:///modules/VCardUtils.jsm:63:19
vCardToAbCard@resource:///modules/VCardUtils.jsm:142:25
convertToHTML@resource:///modules/VCardUtils.jsm:309:27

There's not much to read from the error/stack, other than the method is not built to handle multiple contacts.

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Attachment: Demo email with x-vcard attachment with single contact

Here's a message with a x-vcard attachment that only contains one contact, which you can open for comparison to see the expected behaviour.