1717988 - Port bug 1713036 to Thunderbird - Update DoH Preferences UI to work with Remote Settings config

Status: VERIFIED FIXED

(Thunderbird :: Upstream Synchronization, defect, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1713036 +++

Port https://hg.mozilla.org/mozilla-central/rev/06800c1388fb

DoHController.jsm is Firefox only (in browser/). Should that live in toolkit?

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Hi Magnus, that file should not live in toolkit/ - it does work that's very specific to our regional rollouts of DoH in Firefox, like heuristics to detect parental controls, the global canary, and enterprise settings.

Note that DNS over HTTPS as a protocol lives in netwerk/, and can be configured via network.trr.* prefs.

As for porting bug 1713036 to Thunderbird - the main thing that affects Thunderbird (I think) is that network.trr.uri is now set to an empty string in all.js, and its previous default value was moved into network.trr.default_provider_uri. I suspect all that's necessary is to add a line like this into mail/app/profile/all-thunderbird.js:

pref("network.trr.uri", "https://mozilla.cloudflare-dns.com/dns-query");

This should essentially restore behavior from before the patch, without needing much rework of the TB-specific preferences UI code.

Hopefully that helps unblock a patch here; let me know if I can be of further help (I don't have a c-c clone/build setup right now, otherwise I would have just tried to make a patch).

Comment 2

[Magnus Melin [:mkmelin]]

Thanks Ninanth!

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1717988 - Port bug 1713036 to Thunderbird - DoH Preferences. r=freaktechnik

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/30f4312003e9
Port bug 1713036 to Thunderbird - DoH Preferences. r=freaktechnik

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9230601 [details]
Bug 1717988 - Port bug 1713036 to Thunderbird - DoH Preferences. r=freaktechnik

[Triage Comment]
Approved for beta.

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 91.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/fbf9fa187a5c

Comment 7

[WaltS48 [:walts48]]

Verified using Thunderbird 91.0b4 on Fedora Linux.