1718194 - Rewrite nsMessageManagerScriptExecutor::LoadScriptInternal based on stencil

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

nsMessageManagerScriptExecutor::LoadScriptInternal uses 2 cache:

• nsMessageManagerScriptHolder in nsMessageManagerScriptExecutor::sCachedScripts
• ScriptPreloader::GetCachedStencil, used from TryCacheLoadAndCompileScript

After bug 1688788, ScriptPreloader uses stencil, and nsMessageManagerScriptExecutor::TryCacheLoadAndCompileScript is rewritten to use stencil for ScriptPreloader's cache.

We should rewrite nsMessageManagerScriptHolder also to use stencil, so that ExecuteInFrameScriptEnvironment and JS::CloneAndExecuteScript call in nsMessageManagerScriptExecutor::LoadScriptInternal can be removed.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1718194 - Use stencil in nsMessageManagerScriptExecutor. r?tcampbell!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa56fe2c069d
Use stencil in nsMessageManagerScriptExecutor. r=tcampbell,kmag

Comment 4

[Atila Butkovits]

Backed out for causing leaks.

Backout link: https://hg.mozilla.org/integration/autoland/rev/67b1f53e79bbd755fb285606dcd246b5ae131295

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=cm4Ib7QxR1SVp5Lp0SBCVQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1cd8bdf1fc92414f6e3a0784ac37e8fe31a64771

Failure log: https://treeherder.mozilla.org/logviewer?job_id=351989321&repo=autoland&lineNumber=3022

Comment 5

[Andreea Pavel [:apavel]]

Backout merged to central https://hg.mozilla.org/mozilla-central/rev/67b1f53e79bbd755fb285606dcd246b5ae131295

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/726828578df1
Use stencil in nsMessageManagerScriptExecutor. r=tcampbell,kmag

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/726828578df1