1718521 - [XFA] An image element is incorrectly rendered

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user loads a specific PDF file in Adobe Reader and Firefox, an image element is incorrectly displayed in the browser.

Affected versions

• Nightly v91.0a1

Affected platforms

• all

Preconditions

• Flip the "pdfjs.enableXfa" pref to true.

Steps to reproduce

1. Launch browser.
2. Load the attached PDF file.
3. Go to the end of page 1, Section 10, b.

Expected result

• An arrow-like element is shown, pointing to the right.

Actual result

• An incorrect element is rendered, looks like a checkbox.

Regression range

• Not a regression, but an implementation fault.

Comment 1

[Daniel Bodea [:danibodea]]

Attachment: imm5257e.pdf

PDF in question.

Comment 2

[Daniel Bodea [:danibodea]]

Attachment: incorrect image element rendered.png

Demo.

Comment 3

[Calixte Denizet (:calixte)]

The image here is in tiff format which is not supported in firefox.
So we should add a tiff decoder to pdf.js.

Comment 4

[Daniel Bodea [:danibodea]]

Attachment: PDFBOX-2045-0-GOOD.pdf

This PDF has an image that the browser won't display. Demo below.

Comment 5

[Daniel Bodea [:danibodea]]

Attachment: image missing.png

Comment 6

[Daniel Bodea [:danibodea]]

Attachment: pdf.js-LINK-1773-1-GOOD.pdf

Another logo image missing from the browser's rendering.

Comment 7

[Daniel Bodea [:danibodea]]

Attachment: missing image 3.png

Demo for the PDF above.

Comment 8

[Daniel Bodea [:danibodea]]

Attachment: Antrag_Abschlussarbeit.pdf

Another one.

Comment 9

[Daniel Bodea [:danibodea]]

Attachment: logo image missing again.png

Comment 10

[Calixte Denizet (:calixte)]

In PDFBOX-2045-0-GOOD.pdf, the image is a jpeg one but instead of being a base64 stream inside the xml itself, it's an embedded binary stream in the pdf.
The href of the image is a string accessible through Names dictionary.

Comment 11

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/b370d4714f6713007af9f0b0f947a949a947d0c1

Commit merged into master by GitHub
Authored by calixteman (calixteman)

Comment 12

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/13672

Comment 13

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/fcd4c8151c31b423ec9c10e57446f613f580c104

Commit merged into master by GitHub
Authored by calixteman (calixteman)

Comment 14

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/13673

Comment 15

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/ba2d6851665c6d2b41e6dca8cd768630c4af27ea

Commit merged into master by GitHub
Authored by calixteman (calixteman)

Comment 16

[Marco Castelluccio [:marco]]

Could you verify the PDFs from this bug are fixed?
Except imm5257e.pdf, for which we should file a separate bug to add support for the TIFF format.

Comment 17

[Daniel Bodea [:danibodea]]

Test results:

• imm5257e.pdf - not fixed.
• PDFBOX-2045-0-GOOD.pdf - FIXED.
• pdf.js-LINK-1773-1-GOOD.pdf - FIXED.
• Antrag_Abschlussarbeit.pdf - FIXED.

Verified as fixed based on the last comment.
Logging a new issue for the one that is not fixed: bug 1719750.