1718528 - [XFA & AcroForm] Checkboxes and radio buttons have no focus indicator when navigating via keyboard

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: evince-1157-0-GOOD.pdf

Tested with:

Nightly 91.0a1 (2021-06-28)

Tested on:

Windows 10

Steps:

1. Launch the browser.
2. Flip the pdfjs.enableXfa to true.
3. Load the attached PDF file.
4. Using the keyboard only, navigate to any checkboxes.

Actual result:

The checkboxes are not highlighted when are in focus and the user doesn't know where the focus is.

Expected result:

The checkboxes should have highlight when navigate with the keyboard.

Comment 1

[Alin Ilea, Desktop Test Engineering]

Attachment: 2021-06-28_14h52_21.mp4

Comment 2

[Morgan Reschenberg [:morgan]]

Note this is applicable to both checkboxes and radio buttons

Comment 3

[Marco Castelluccio [:marco]]

This is not specific to XFA forms, it can be reproduced on AcroForm too (e.g. https://tcpdf.org/files/examples/example_054.pdf or https://raw.githubusercontent.com/mozilla/pdf.js/master/test/pdfs/annotation-button-widget.pdf).

Comment 4

[Marco Castelluccio [:marco]]

This appears to be due to the outline: none property on the checkboxes and radio buttons.

Comment 5

[Marco Castelluccio [:marco]]

That property was added back in https://github.com/mozilla/pdf.js/pull/4203, for the PDF viewer UI.

Comment 6

[Marco Castelluccio [:marco]]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/13875

Comment 7

[Daniel Bodea [:danibodea]]

I can confirm that both the checkboxes and radio buttons are properly visually highlighted in Nightly v93.0a1 and Beta v92.0b4, as opposed to Release v91.0, in the case of this PDF and few others. This will be properly verified by the end of the preliminary testing session for this feature.

It's important to mention that bug 1723931 behavior is observed in this specific PDF and I can confirm that Adobe Reader also shows this behavior, which confirms the fact that the PDF is broken by itself.