1741445 - Update ESR to pdf.js version 2.11.298

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, task)

Description

[Brendan Dahl [:bdahl]]

This main reason for this uplift is XFA support.

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: Bug 1741445 - Update ESR to pdf.js version 2.11.298 r=#pdfjs-reviewers

Comment 2

[Brendan Dahl [:bdahl]]

Comment on attachment 9250972 [details]
Bug 1741445 - Update ESR to pdf.js version 2.11.298 r=#pdfjs-reviewers

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This adds XFA form support which seems to be relatively common in enterprise settings.
• User impact if declined: No XFA support. There are also several bug fixes and regression fixes that will come along with this update.
• Fix Landed on Version: 94
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This will enable a whole new feature, but we haven't received many major bugs filed about the new XFA support, so it seems relatively safe. We could always disable with a pref if needed.
• String or UUID changes made by this patch:

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Are we planning to do this as a one-off or pick up future releases as well as XFA support matures?

Comment 4

[Brendan Dahl [:bdahl]]

I'd lean towards doing a one-off and then cherry-picking any significant XFA fixes.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9250972 [details]
Bug 1741445 - Update ESR to pdf.js version 2.11.298 r=#pdfjs-reviewers

This is something which would normally not be a candidate for ESR uplift given that it's a wholesale feature uplift, but I think it's justified in this case:

• It's a very self-contained feature which doesn't affect the rest of the browser operation and has good upstream test coverage.
• The primary driver is XFA support, which is something more heavily used in enterprise environments.
• It's pref controlled for easy disabling if needed.

Approved for 91.4esr. That said, we should probably get QA to do some extra verification around this. Also, do we need to uplift any enterprise policy changes around this Mike?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/a88ddb41651c

Comment 7

[Mike Kaply [:mkaply]]

Nope, no policy changes.

Comment 8

[Raluca Popovici, Desktop QA]

We did a smoke run on 91.4esr on MacOS 11, Ubuntu 20 and Win 10. I'll mark this bug as verified fixed.