1719540 - Unify Intl APIs in dom/indexedDB/IndexedDatabaseManager.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

Work: Small
What it is: a single call to validate a locale

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719540 - Implement a unified Locale canonicalizer; r?dminor

I used the C api here, but verified that the behavior was the same
as using the C++ getBaseName API.

https://github.com/gregtatum/spec-cpp/blob/927fee5656e4e8f371a42a9ab6ba92732813fc3e/src/features/icu.cpp#L249-L268

I tried to keep the implementation naming at least similar to the
work in: https://phabricator.services.mozilla.com/D118070

However, the implementation do diverge. I figure in the future, the
APIs can be made similar, but at least the gtests will ensure the
behavior remains the same.

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719540 - Used mozilla::intl::LocaleCanonicalizer in IndexedDB; r?#dom-storage,dminor

As part of the effort to unify the ICU calls, this replaces the calls for locale
canonicalization in IndexedDB code with the unified component. See Bug 1719664 for
more information.

Depends on D120248

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8b05f56aa75
Implement a unified Locale canonicalizer; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/a6ab150a89f2
Used mozilla::intl::LocaleCanonicalizer in IndexedDB; r=dom-storage-reviewers,asuth

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1719540) for causing bustages in RelativeTimeFormat.cpp
Backout link: https://hg.mozilla.org/integration/autoland/rev/abc2e73b5c35375010a986b3fdb32b6371a4534c
Push with failures, failure log.

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1719540 - Fix unified build imports bustages for mozilla::intl; r?dminor

Depends on D120249

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf740f76c524
Implement a unified Locale canonicalizer; r=platform-i18n-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/fe76bdb1a6ad
Used mozilla::intl::LocaleCanonicalizer in IndexedDB; r=dom-storage-reviewers,asuth
https://hg.mozilla.org/integration/autoland/rev/0c59471463aa
Fix unified build imports bustages for mozilla::intl; r=dminor

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/bf740f76c524
https://hg.mozilla.org/mozilla-central/rev/fe76bdb1a6ad
https://hg.mozilla.org/mozilla-central/rev/0c59471463aa