1719554 - Unify Intl APIs in intl/unicharutil/util/nsUnicodeProperties.h

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Greg Tatum [:gregtatum]]

Work: Medium
What it is: Various calls to unicode property APIs

https://searchfox.org/mozilla-central/source/intl/unicharutil/util/nsUnicodeProperties.h

Comment 1

[Dan Minor [:dminor]]

This is a candidate to build a unified abstraction over along the lines of Collator. Greg or I will look at it.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1719554 - Unify most of nsUnicodeProperties.h; r=#platform-i18n-reviewers!

This unifies most of the calls in nsUnicodeProperties.h. CharType and Script
will be handled in subsequent patches on this bug.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1719554 - Unify nsCharType as intl::BidiClass; r=#platform-i18n-reviewers!

Depends on D132273

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1719554 - Unify unicode::Script as intl::Script; r=#platform-i18n-reviewers!

Depends on D132275

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/221ec418475c
Unify most of nsUnicodeProperties.h; r=platform-i18n-reviewers,jfkthame,gregtatum,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/c261ede6ae81
Unify nsCharType as intl::BidiClass; r=platform-i18n-reviewers,jfkthame,gregtatum
https://hg.mozilla.org/integration/autoland/rev/6181e40d4da1
Unify unicode::Script as intl::Script; r=platform-i18n-reviewers,gregtatum

Comment 6

[Atila Butkovits]

Backed out for causing bustages complaining about gfxTextRun.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e3bb9e7d1b5a7a916bd26340dc13cb8d29411228

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6181e40d4da1f9ff1b744e089cc51ba113fcdeb4&selectedTaskRun=MVvZBYjuQVGveoLlTjwuhA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=360125743&repo=autoland&lineNumber=53987

Comment 7

[Dan Minor [:dminor]]

Fix for Bp-hybrid build: https://treeherder.mozilla.org/jobs?repo=try&revision=54ceac3c6630aa26016bd87cab73a58c5b4ac3e9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/549c29e15597
Unify most of nsUnicodeProperties.h; r=platform-i18n-reviewers,jfkthame,gregtatum,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/16a5839b0bc3
Unify nsCharType as intl::BidiClass; r=platform-i18n-reviewers,jfkthame,gregtatum
https://hg.mozilla.org/integration/autoland/rev/c29a014eaef3
Unify unicode::Script as intl::Script; r=platform-i18n-reviewers,gregtatum

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/549c29e15597
https://hg.mozilla.org/mozilla-central/rev/16a5839b0bc3
https://hg.mozilla.org/mozilla-central/rev/c29a014eaef3

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/614f2baba4ed
Port bug 1719554 - Unify unicode::Script as intl::Script. rs=bustage-fix