Clean up for nsComboboxControlFrame
Categories
(Core :: Layout: Form Controls, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(4 files)
Placeholder for my patches to clean up nsComboboxControlFrame.
|
Assignee | |
Comment 1•3 years ago
|
||
The usage was removed in bug 300030 [1] in the removed chunk between
line 563 and 564.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Bug 326944 removed nsIComboboxControlFrame in
https://hg.mozilla.org/mozilla-central/rev/785a53ae44c0
Bug 579323 removed nsIFrameFrame in
https://hg.mozilla.org/mozilla-central/rev/b002a8eb529f
Bug 328680 removed nsIListControlFrame in
https://hg.mozilla.org/mozilla-central/rev/d081601f722b
Bug 670148 removed nsIMenuFrame in
https://hg.mozilla.org/mozilla-central/rev/09df029315a7
Depends on D119339
|
|
Assignee | |
Comment 3•3 years ago
|
||
This patch is similar to Emilio's cleanup in Bug 1590278.
Depends on D119340
|
|
Assignee | |
Comment 4•3 years ago
|
||
This patch removed the unused code which introduced by Bug 1571764
because Bug 1560824 moves the padding-block style to <select>'s UA
rule, so now nsComboboxDisplayFrame doesn't have any padding in the
block axis.
Depends on D119341
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/661f02584330 Part 1 - Removed an unused #define in nsComboboxControlFrame.cpp. r=hiro https://hg.mozilla.org/integration/autoland/rev/f97a644bef6a Part 2 - Remove unused AbstractFrame classes in FrameClasses.py. r=hiro https://hg.mozilla.org/integration/autoland/rev/6471338e2044 Part 3 - Replace virtual & override specifier with final for combobox frames. r=hiro https://hg.mozilla.org/integration/autoland/rev/cf5570dac55e Part 4 - Remove unused code subtracting block and padding from block-size for nsComboboxDisplayFrame. r=emilio
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/661f02584330
https://hg.mozilla.org/mozilla-central/rev/f97a644bef6a
https://hg.mozilla.org/mozilla-central/rev/6471338e2044
https://hg.mozilla.org/mozilla-central/rev/cf5570dac55e
Description
•