Closed Bug 1719555 Opened 4 months ago Closed 4 months ago

Clean up for nsComboboxControlFrame

Categories

(Core :: Layout: Form Controls, task)

task

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(4 files)

Placeholder for my patches to clean up nsComboboxControlFrame.

This patch is similar to Emilio's cleanup in Bug 1590278.

Depends on D119340

This patch removed the unused code which introduced by Bug 1571764
because Bug 1560824 moves the padding-block style to <select>'s UA
rule, so now nsComboboxDisplayFrame doesn't have any padding in the
block axis.

Depends on D119341

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/661f02584330
Part 1 - Removed an unused #define in nsComboboxControlFrame.cpp. r=hiro
https://hg.mozilla.org/integration/autoland/rev/f97a644bef6a
Part 2 - Remove unused AbstractFrame classes in FrameClasses.py. r=hiro
https://hg.mozilla.org/integration/autoland/rev/6471338e2044
Part 3 - Replace virtual & override specifier with final for combobox frames. r=hiro
https://hg.mozilla.org/integration/autoland/rev/cf5570dac55e
Part 4 - Remove unused code subtracting block and padding from block-size for nsComboboxDisplayFrame. r=emilio
You need to log in before you can comment on or make changes to this bug.