1719558 - After reducing Thunderbird's composer window width, `From` field is no longer vertically aligned with other address rows

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P4)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: `From` not vertically aligned with other address rows with reduced-width TB window

91.0a1 (2021-07-06) (64-bit), Win10

After reducing Thunderbird's main window width, From field is no longer vertically aligned with other address rows (see screenshot). Must be some sort of wrong calculation or rounding error. Gets worse the more you shrink 3-pane window horizontally, goes away when 3-pane is maximized. This looks odd and a bit unfinished.

Comment 1

[Alessandro Castellani [:aleca]]

Richard, any guess on what's causing this?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1719558-composer-flex-issues.patch

The .aw-firstColBox in front of the From: label still shrunk.

Additionally I added a limited flexibility to the format toolbar with shrinking menulists. What do you think about this? I could also stop the flex on the paragraph menulist but with other locales this could be use longer labels.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9230222 [details] [diff] [review]
1719558-composer-flex-issues.patch

Review of attachment 9230222 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes the "Form" column unwanted shrinking, but the edits to the menulists cause some UI changes.
The list are now darker and the padding around the toolbar changed.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: compose-style.png

LEFT: without patch
RIGHT: with patch

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1719558-composer-flex-issues.patch

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9230418 [details] [diff] [review]
1719558-composer-flex-issues.patch

Review of attachment 9230418 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Please, update the commit message with: "Prevent unwanted resize of the 'From' container in message compose, and enable flex shrink for the format toolbar menulists."

Comment 7

[Richard Marti (:Paenglab)]

Attachment: 1719558-composer-flex-issues.patch

Updated the commit message.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4d556740abd8
Prevent unwanted resize of the 'From' container in message compose, and enable flex shrink for the format toolbar menulists. r=aleca