1720041 - HTML toolbar shows up in plaintext mode with `Compose in HTML format` unchecked in account settings

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Formatting toolbar still shows up in plain text composition

+++ This bug was initially created as a clone of Bug #1720038 +++

Regression range:
Per Bug #1720038, this problem appeared in Daily 2021-07-09, not seen on 2021-07-08.

I verified it's not seen on 2021-07-07 and seen on 2021-07-11.
Tested on 91.0a1 (2021-07-11) (64-bit)

STR

1. ≡ > Account Settings > YourAccount > Composition & Addressing > uncheck: [ ] Compose in HTML Format to compose with plain text editor
2. Select YourAccount in folder pane, then Write

Actual Result (see screenshot):

• HTML formatting toolbar shows with most, but not all options disabled.
• Variable width is irritatingly selected in Font selector (but correctly not applied)
• Set font size button is enabled and functional, changes font size on screen (but correctly not sent as HTML, so it won't apply).

Expected Result

• Hide formatting toolbar as we did until some days ago, as per current design user cannot use it for plain text.
• If possible, figure out why some options are still enabled, and why Variable font is wrongly showing.

Comment 2

[José M. Muñoz]

I've confirmed the regression range between 8th and 9th of July, which makes it this:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a3b5e92bc304&tochange=98cc2530f612

I backed out the suspicious looking bug 1719558
https://hg.mozilla.org/comm-central/rev/4d556740abd845c1efd9633d7ddc12a60c815d59
and the problem was gone.

Most likely something went wrong with this observer here: observes="cmd_renderedHTMLEnabler"

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1720041-formatToolbar-flex.patch

Thanks José for finding the regression. It's not an observer issue. The display: flex; simply overrides the hidden="true" when in plaintext.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c83e10ec2319
Set the display: flex; on the FormatToolbar only in composer's HTML mode. r=aleca

Comment 5

[Calum Mackay]

Verified in MacOS Daily 0712, thanks very much indeed.

Comment 6

[Thomas D. (:thomas8)]

Awesome teamwork, thanks everyone! Such a joy to see swift action after making bugs actionable! :-)

Verified FIXED on 91.0a1 (2021-07-12) (64-bit) Win10, and per comment 5 on MacOS.