1719734 - Enable widget.macos.support-dark-appearance by default on Release

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P2)

Comment 1

[Harry Twyford]

Attachment: Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r?#mac-reviewers

Comment 2

[Harry Twyford]

[Tracking Requested - why for this release]:

This feature is currently enabled for Early Beta. This bug is just the pref-flip to enable it for Release. Product would like it in 91. There's only one more bug deemed blocking, which is bug 1710934. It's a small patch that's in review.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74a832b24286
Enable widget.macos.support-dark-appearance by default on Release. r=mac-reviewers,mstange

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in toolkit/components/extensions/test/browser/browser_ext_themes_highlight.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0d1bbf9e767366b810abe835e6c5126dd7b0bc38

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdf8efe12935
Enable widget.macos.support-dark-appearance by default on Release. r=mac-reviewers,mstange

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bdf8efe12935

Comment 7

[Pascal Chevrel:pascalc]

(In reply to Harry Twyford [:harry] from comment #2)

[Tracking Requested - why for this release]:

This feature is currently enabled for Early Beta. This bug is just the pref-flip to enable it for Release. Product would like it in 91. There's only one more bug deemed blocking, which is bug 1710934. It's a small patch that's in review.

Harry, is that still planned for 91 with an uplift to beta or will it ship with 92 train? Thanks

Comment 8

[Harry Twyford]

Comment on attachment 9230342 [details]
Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r?#mac-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: We want to ship this new feature in Firefox 91. macOS users will see improved dark mode support. It's already being tested on early Beta; this patch is just a pref flip that enables it on Release.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1710934
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Already tested on early beta with no regressions reported.
• String changes made/needed:

Comment 9

[Albert Scheiner [:alberts]]

👏👏

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9230342 [details]
Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r?#mac-reviewers

Uplift of a planned feature activation, approved for 91 beta 3, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6415d020b4d