1720115 - The Debugger tab should be properly unhighlighted when pausing between frames

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Hubert Boma Manilla (:bomsy)]

Prefs:

• fission.autostart => true
• devtools.target-switching.server.enabled => true
• fission.bfcacheInParent => true

STR

1. Load http://janodvarko.cz/tests/fission/case9/index.html (two iframes loaded from the same remote domain)
2. Create BP in odvarko.com/tests/fission/case9/iframe1.js, line 6
3. Create BP in odvarko.com/tests/fission/case9/iframe2.js, line 6
4. Click the the POST1 button (in the first frame), Debugger should pause, step over one time
5. Click the the POST2 button (in the second frame), Debugger should pause in the second frame, step over one time & resume
6. Switch to the Test Frame #1 thread and resume.
7. The Debugger tab is still highlighted =>BUG

I think that switching the contexts through the Threads panel should be involved. So, if the steps above don't work for you. Try to play a bit with the UI (context switching, stepping) before resuming both.

Honza

Comment 1

[Hubert Boma Manilla (:bomsy)]

The issue here seems to be that we do not include the resumeLimit reason here(e.g is set when a step-over is clicked) which causes the pauseTargets count here to break and go into -ve values, so this never gets called and unhighlight does not happen.

Comment 2

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1720115 - [devtools] Also check thread state resources where reason => 'resumeLimit' to maintain pauseTargets count

Comment 3

[Hubert Boma Manilla (:bomsy)]

Hi Honza,
Could you confirm that this also fixes the issue for you, when you have a chance

Thanks

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Hubert Boma Manilla (:bomsy) from comment #3)

Could you confirm that this also fixes the issue for you, when you have a chance

Yes, the issue is fixed when I test with the patch applied.
Thank you Hubert for quick analysis and fix!

Honza

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac0806a43c11
[devtools] Also check thread state resources where reason => 'resumeLimit' to maintain pauseTargets count r=jdescottes

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ac0806a43c11