1720763 - Remove pre-MR1 onboarding topSites by region support

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

With proton onboarding, we no longer display static topSites by region on import screen. Scope of this bug is to

• remove logic from onboarding flow to retrieve static topSites by region
• check with product and if no plan to use in future remove dynamic importable topsites

https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#157

Comment 1

[Punam Dahiya [:pdahiya]]

NI Ana to decide if we will be leveraging pre-importable topSites work in future onboarding flows

Comment 2

[Punam Dahiya [:pdahiya]]

Attaching screenshots of static and dynamic topsites support in pre-MR1 onboarding flow. Thanks

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: StaticTopSites_ByRegion.png

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: Static-topsites-telemetry.png

Comment 5

[Punam Dahiya [:pdahiya]]

Attachment: DynamicTopSites.png

Comment 6

[Punam Dahiya [:pdahiya]]

Attachment: Dynamic-topsites-telemetry.png

Comment 7

[Ed Lee :Mardak]

https://phabricator.services.mozilla.com/D120038 is removing the usage of topsites but kept the hooks to initialize the data in MultiStageAboutWelcome.jsx. If all the topsites related code is removed, we should probably also remove parent/child messaging/helpers, e.g., AWGetImportableSites and AWPage:IMPORTABLE_SITES. There might be other unused messaging such as AWIsDefaultBrowser, AWPage:GET_REGION.

Comment 8

[Punam Dahiya [:pdahiya]]

See also related bug 1704128

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:tspurway, since the bug has high priority, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Emily McMinn :emcminn]

Attachment: Bug 1720763 - Remove topsites & region support from about:welcome

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abb6d40d0284
Remove topsites & region support from about:welcome r=pdahiya,omc-reviewers

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/abb6d40d0284