1721218 - Some PDFs fill the RAM completely

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Wilhelm]

Attachment: Screenshot 2021-07-19 190054.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

1. Open this PDF: https://dl.ubnt.com/datasheets/edgemax/EdgeRouter_DS.pdf
   or alternatively this one: https://dl.ubnt.com/ds/uf_gpon
2. Scroll down to around the 3rd Page

Actual results:

The complete RAM of my System was filled in about 10 seconds, and the 3rd Page did not render

Expected results:

The RAM usage should remain somewhat stable when opening the PDFs

Comment 1

[Wilhelm]

Oh I forgot to add: This behavior does not appear in Firefox 89

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::PDF Viewer' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Jonas Jenwald [:Snuffleupagus]]

Mozregression gives the following pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5c402eaa028455bb2c837bb0068741f43d566787&tochange=1a154c35b1b1673c4e9f79c0f38c3d12daa71a6b

Hence this ought to be a regression from https://github.com/mozilla/pdf.js/pull/13361, since that's the most likely one from the list in bug 1711106.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1711106

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/13770

Comment 6

[Pascal Chevrel:pascalc]

Marco, is that patch part of the recent uplift of pdf.js in Beta 91?

Comment 7

[Marco Castelluccio [:marco]]

(In reply to Pascal Chevrel:pascalc from comment #6)

Marco, is that patch part of the recent uplift of pdf.js in Beta 91?

No, it should be in the next update of pdf.js (today's update), which we are also planning to uplift.

Comment 8

[Marco Castelluccio [:marco]]

Still very slow to render, but it doesn't fill the RAM completely anymore.

Comment 9

[Marco Castelluccio [:marco]]

Should we file a bug/issue about improving perf when rendering this PDF?

Comment 10

[Marco Castelluccio [:marco]]

Bug 1722352 was uplifted to 91.

Comment 11

[Marco Castelluccio [:marco]]

(In reply to Marco Castelluccio [:marco] from comment #9)

Should we file a bug/issue about improving perf when rendering this PDF?

Note: the slow rendering is not a regression, this PDF has always been slow to load!

Comment 12

[Daniel Bodea [:danibodea]]

Just like in bug 1722571, I have confirmed the issue in Firefox Release v90.0.2 and I have verified the fix in Firefox Beta v91.0b9 and Firefox Nightly v92.0a1 from 2021-07-30. The PDF still loads quite slow, but it does not use an absurdly high amount of RAM or get freezes or hangs.