1721264 - In dark mode, tooltip text is unreadable (white on yellow background); in folderpane and threadpane for example

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[alta88]

Seen on linux, at least.

Comment 1

[Richard Marti (:Paenglab)]

Not very helpful bug description with no STR. I occupy this bug to make the tooltips use colours depending of the theme group.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1721264-tooltip-theme-aware.patch

Alessandro, what do you think about this approach? We can't use theme colours as the variables aren't loaded into tooltips. I made three groups: light, dark and high contrast.

Also the dimensions are the same on the platforms as a compromise. Normally Linux uses bigger tooltips than the other platforms. Now they are a bit bigger on Mac and Linux and a bit smaller on Linux.

Comment 3

[alta88]

STR is pretty evident from the summary: be in dark mode, hover a cropped item in folderpane/threadpane :\

I don't know that tooltips need to be theme aware, there is no change in tooltips in dark mode in Firefox. All that needs to be done is to ensure currentColor is not inherited by the tooltip text but that it remains dark on yellow bg.

Comment 4

[Richard Marti (:Paenglab)]

On Linux it's always white on black here, no matter what TB theme is used. On FX the tab and bookmark tooltips are themed...and multiline.

With my patch the tooltips follow the TB theme and not the system theme.

Comment 5

[Alessandro Castellani [:aleca]]

On Linux it's always white on black here, no matter what TB theme is used.

Same here, I can't reproduce the issue.
Could you specify which tooltips are not looking correct?
Is this on 78 or daily?
Also a screenshot/screencast of the problem would be useful.

Comment 6

[alta88]

Attachment: Screenshot at 2021-07-22 13-25-39.png

It's fine on 78; the screenshot is from today's daily (but it also happens on beta) - no extensions.

Comment 7

[Alessandro Castellani [:aleca]]

I'm a bit concerned about this.

I can't reproduce this issue even if I tried in multiple distros with both OS dark mode and/or TB dark theme.
I'd like to get more info to identify/reproduce the problem and what's causing it, rather than forcing some custom styling to bypass the issue.

A bunch of more questions:

• Does it happen for every tooltip?
• What dark theme are you using? OS or TB?
• If OS, what theme are you using? (Adwaita dark, etc,)
• GTK, KDE, or something else?
• Does it happen with Firefox as well?

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1721264-tooltip-theme-aware.patch

I found a use case: on Mac set the system dark theme and on TB a light theme. The tooltip have now a black text on dark background. Happens also vice versa.

Added imtooltip. Needed separated files as Mac is again a bit different.

Comment 9

[alta88]

(In reply to Alessandro Castellani [:aleca] from comment #7)

I'm a bit concerned about this.

I can't reproduce this issue even if I tried in multiple distros with both OS dark mode and/or TB dark theme.
I'd like to get more info to identify/reproduce the problem and what's causing it, rather than forcing some custom styling to bypass the issue.

A bunch of more questions:

• Does it happen for every tooltip?

Yes, cropped tabs too..

• What dark theme are you using? OS or TB?

Tb dark theme.

• If OS, what theme are you using? (Adwaita dark, etc,)

Linux Mint Mint-x non dark.

• GTK, KDE, or something else?

Gnome, GTK.

• Does it happen with Firefox as well?

No, Fx 92 has tabs and library (nsITree still) crops with dark bg and light text tooltips.

Comment 10

[Richard Marti (:Paenglab)]

Attachment: 1721264-tooltip-theme-aware.patch

Fixed an issue with the QFB search tooltip.

Comment 11

[Alessandro Castellani [:aleca]]

Comment on attachment 9235019 [details] [diff] [review]
1721264-tooltip-theme-aware.patch

Review of attachment 9235019 [details] [diff] [review]:
-----------------------------------------------------------------

This solves the issue you found, which I can reproduce on macOS.
But I don't think we should go this way of forcibly applying our own style to the tooltip. With this, the TB tooltips on Linux look completely different from all the other tooltips styled by the desktop environment.

Comment 12

[Richard Marti (:Paenglab)]

We do on other places an unified style with reduced platform styling. This would be another place we could do this.

When we don't do this how could we resolve the issue?

Comment 13

[alta88]

This issue no longer happens on current nightly, so something somewhere (toolkit?) changed. I think it's important to uplift the change to 91, as it is still present in 91.0.2.

Comment 14

[Alessandro Castellani [:aleca]]

Thanks for checking.
Indeed something must have changed in the toolkit since we haven't touched this.
Let the regression hunt begin.

Comment 15

[Phil Pishioneri]

I opened bug 1732987 for similar issue on macOS: don't know if it's a duplicate of this since it's on a different operating system.

Comment 17

[Richard Marti (:Paenglab)]

There are still issues with dark Mac system theme. What do you think could be done further?

Comment 18

[Curt Blank]

(In reply to Richard Marti (:Paenglab) from comment #17)

There are still issues with dark Mac system theme. What do you think could be done further?

Change the font color to white in the Hints/Tooltips and Menus.

Comment 19

[Curt Blank]

(In reply to Richard Marti (:Paenglab) from comment #12)

We do on other places an unified style with reduced platform styling. This would be another place we could do this.

When we don't do this how could we resolve the issue?

And. Why do I have this issue in the first place when I have Light theme enabled and Dark theme is disabled?

Comment 20

[ramdas.tro]

Problem persists

macOS Monterey 12.0.1
Thunderbird 91.3.0

Comment 21

[Alessandro Castellani [:aleca]]

Emilio, do you have any suggestion for this issue?

Comment 22

[Richard Marti (:Paenglab)]

Tested with TB95 beta and the tooltips are working correctly with dark system theme and light TB theme.

Comment 23

[Alessandro Castellani [:aleca]]

So maybe this was fixed by bug 1736252?

Comment 24

[Emilio Cobos Álvarez (:emilio)]

Yep, that's the kind of issue that patch can fix.

Comment 25

[Alessandro Castellani [:aleca]]

Marking this as duplicate of bug 1736252, which is listed for the next 91 uplift.
We can reopen it if it's not fixed by then.

Comment 26

[Richard Marti (:Paenglab)]

Attachment: Bug 1721264 - Make the tooltips theme aware. r=aleca

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f146a3e57afd
Make the tooltips theme aware. r=aleca